Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13601030: [android] Improve logging output. (Closed)

Created:
7 years, 8 months ago by craigdh
Modified:
7 years, 8 months ago
Reviewers:
frankf
CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

[android] Improve logging output. BUG=160320 TEST=ran the tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193143

Patch Set 1 #

Patch Set 2 : modify format #

Total comments: 2

Patch Set 3 : added comments #

Patch Set 4 : logging.Formatter doesn't always inherit from object, can't use super() #

Patch Set 5 : old Python compatability #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -3 lines) Patch
M build/android/pylib/cmd_helper.py View 4 chunks +4 lines, -2 lines 0 comments Download
M build/android/pylib/utils/run_tests_helper.py View 1 2 3 4 2 chunks +25 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
craigdh
New log output looks something like this. Suggestions to improve it welcome. W[ 78 s]: ...
7 years, 8 months ago (2013-04-06 00:10:50 UTC) #1
craigdh
New log output looks something like this. Suggestions to improve it welcome. W[ 78 s]: ...
7 years, 8 months ago (2013-04-06 00:11:26 UTC) #2
craigdh
ptal. W 46s Message goes here foo bar.
7 years, 8 months ago (2013-04-06 00:17:25 UTC) #3
frankf
lgtm https://codereview.chromium.org/13601030/diff/4001/build/android/pylib/utils/run_tests_helper.py File build/android/pylib/utils/run_tests_helper.py (right): https://codereview.chromium.org/13601030/diff/4001/build/android/pylib/utils/run_tests_helper.py#newcode13 build/android/pylib/utils/run_tests_helper.py:13: def __init__(self, fmt=''): comments. https://codereview.chromium.org/13601030/diff/4001/build/android/pylib/utils/run_tests_helper.py#newcode41 build/android/pylib/utils/run_tests_helper.py:41: ch.setFormatter(CustomFormatter()) ch ...
7 years, 8 months ago (2013-04-06 00:20:53 UTC) #4
craigdh
7 years, 8 months ago (2013-04-09 18:06:32 UTC) #5
Message was sent while issue was closed. 
Committed patchset #5 manually as r193143 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698