Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2346)

Unified Diff: dart/tools/build.py

Issue 13601019: Restore incremental output. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/tools/build.py
diff --git a/dart/tools/build.py b/dart/tools/build.py
index 886749f6ef77e868f687e1571867cc989ebdffca..a0ecf14f122bfd08aed80dea099c272f323a62f0 100755
--- a/dart/tools/build.py
+++ b/dart/tools/build.py
@@ -273,11 +273,11 @@ PhaseScriptExecution "Action \"upload_sdk_py\"" xcodebuild/dart.build/...
is_fancy_tty = True
except subprocess.CalledProcessError:
is_fancy_tty = False
+ has_interesting_info = False
for line in unbuffered(process.stdout.readline):
line = line.rstrip()
if line.startswith('=== BUILD ') or line.startswith('** BUILD '):
- if not is_empty_chunk(chunk):
- print '\n'.join(chunk)
+ has_interesting_info = False
section = line
if is_fancy_tty:
# If stdout is a terminal, emit "progress" information. The
@@ -291,10 +291,19 @@ PhaseScriptExecution "Action \"upload_sdk_py\"" xcodebuild/dart.build/...
# overwrites a longer line.
print '%s%s\r' % (clr_eol, section),
chunk = []
- if not section:
+ if not section or has_interesting_info:
print line
else:
- chunk.append(line)
+ length = len(chunk)
+ if length == 1 and line != 'Check dependencies':
+ has_interesting_info = True
+ elif (length == 2 or length == 3) and line:
+ has_interesting_info = True
+ if has_interesting_info:
+ print '\n'.join(chunk)
+ chunk = []
+ else:
+ chunk.append(line)
if not is_empty_chunk(chunk):
print '\n'.join(chunk)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698