Chromium Code Reviews| Index: chrome/renderer/plugins/plugin_uma.h |
| diff --git a/chrome/renderer/plugins/plugin_uma.h b/chrome/renderer/plugins/plugin_uma.h |
| index f1eb4cf2d701a2a35cc7f89c81291d43224bd2b5..4dc788ea41ab094252e4b591ed8e8f927d8381d6 100644 |
| --- a/chrome/renderer/plugins/plugin_uma.h |
| +++ b/chrome/renderer/plugins/plugin_uma.h |
| @@ -17,14 +17,23 @@ |
| // or, if mime type is unknown, by plugin's src url. |
| class MissingPluginReporter { |
| public: |
| - // This must be sync'd with histogram values. |
| + // Make sure the enum list in tools/histogram/histograms.xml is updated with |
| + // any change in this list. |
| enum PluginType { |
| WINDOWS_MEDIA_PLAYER = 0, |
| SILVERLIGHT = 1, |
| REALPLAYER = 2, |
| JAVA = 3, |
| QUICKTIME = 4, |
| - OTHER = 5 |
| + OTHER = 5, // This is obsolete and replaced by UNSUPPORTED_* types. |
| + BROWSER_PLUGIN = 6, |
| + SHOCKWAVE_FLASH = 7, |
| + WIDEVINE_CDM = 8, |
| + // NOTE: Add new plugin types only immediately above this line. |
| + UNSUPPORTED_MIMETYPE = 240, |
| + UNSUPPORTED_EXTENSION = 241, |
| + // NOTE: Add new unsupported types only immediately above this line. |
| + PLUGIN_TYPE_MAX |
|
ddorwin
2013/04/05 05:32:17
On second thought, any idea if each slot consumes
xhwang
2013/04/05 19:00:09
Moved UNSUPPORTED_* after OTHER to avoid the gap.
|
| }; |
| // Sends UMA data, i.e. plugin's type. |