Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8499)

Unified Diff: chrome/renderer/plugins/plugin_uma.h

Issue 13601002: Report UMA for Shockwave Flash and Widevine CDM. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: resolve comments Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/renderer/plugins/plugin_uma.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/plugins/plugin_uma.h
diff --git a/chrome/renderer/plugins/plugin_uma.h b/chrome/renderer/plugins/plugin_uma.h
index f1eb4cf2d701a2a35cc7f89c81291d43224bd2b5..126cf449232c5ddc759c697ff1cc849047015c94 100644
--- a/chrome/renderer/plugins/plugin_uma.h
+++ b/chrome/renderer/plugins/plugin_uma.h
@@ -17,14 +17,23 @@
// or, if mime type is unknown, by plugin's src url.
class MissingPluginReporter {
public:
- // This must be sync'd with histogram values.
+ // Make sure the enum list in tools/histogram/histograms.xml is updated with
+ // any change in this list.
enum PluginType {
WINDOWS_MEDIA_PLAYER = 0,
SILVERLIGHT = 1,
REALPLAYER = 2,
JAVA = 3,
QUICKTIME = 4,
- OTHER = 5
+ OTHER = 5, // This is obsolete and replaced by
ddorwin 2013/04/05 04:21:37 incomplete sentence
xhwang 2013/04/05 05:05:21 Done.
+ BROWSER_PLUGIN = 6,
+ SHOCKWAVE_FLASH = 7,
+ WIDEVINE_CDM = 8,
+ // NOTE: Add new plugin types only immediately above this line.
+ UNSUPPORTED_MIMETYPE = 240,
+ UNSUPPORTED_EXTENSION = 241,
+ // NOTE: Add new unsupported types only immediately above this line.
+ PLUGIN_TYPE_MAX
};
// Sends UMA data, i.e. plugin's type.
« no previous file with comments | « no previous file | chrome/renderer/plugins/plugin_uma.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698