Report UMA for Shockwave Flash and Widevine CDM.

chrome/renderer/plugins/plugin_uma.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_RENDERER_PLUGINS_PLUGIN_UMA_H_
 #define CHROME_RENDERER_PLUGINS_PLUGIN_UMA_H_
 
 #include <string>
 
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/singleton.h"
 #include "googleurl/src/gurl.h"
 
 // Used to send UMA data about missing plugins to UMA histogram server. Method
 // ReportPluginMissing should be called whenever plugin that is not available or
 // enabled is called. We try to determine plugin's type by requested mime type,
 // or, if mime type is unknown, by plugin's src url.
 class MissingPluginReporter {
  public:
-  // This must be sync'd with histogram values.
   enum PluginType {
     WINDOWS_MEDIA_PLAYER = 0,
     SILVERLIGHT = 1,
     REALPLAYER = 2,
     JAVA = 3,
     QUICKTIME = 4,
-    OTHER = 5
+    OTHER = 5,

[xhwang, 2013/04/03 23:36:55]

This is hacky. I don't want to touch the current histogram values but now it
looks really odd. Thoughts?

[Bernhard Bauer, 2013/04/04 07:01:56]

Haha, guess we should have initially defined OTHER as 0 ;-)

Seriously though, I don't think it makes a huge difference, except that it
appears in the middle of the definition instead of at the beginning or the end.
The whole point of enums is to abstract away the actual values.

On that note, you could remove the individual values here; they don't really add
anything but noise IMO.

[xhwang, 2013/04/05 00:58:18]

Agreed. I don't want to change the existing histogram/counts in case some
one/system is monitoring/depending-on them.
Do you mean to remove entries like REALPLAYER because few users are using them?
For now I'd like to add entries instead of removing any before we have a good
understanding what plugin types are missing.

[Bernhard Bauer, 2013/04/05 13:29:09]

No, I meant there is no need to write out the actual numerical values here if
they're increasing by one anyway.

+    SHOCKWAVE_FLASH = 6,
+    WIDEVINE_CDM = 7,

[ddorwin, 2013/04/04 19:52:24]

If you're trying to reduce "other", I suggest also adding kBrowserPluginMimeType
per my comments in the other CL.

[xhwang, 2013/04/05 00:58:18]

Done.

+    // NOTE: Add new plugin types only immediately above this line. Also, make
+    // sure the enum list in tools/histogram/histograms.xml is updated with any
+    // change here.
+    PLUGIN_TYPE_MAX
   };
 
   // Sends UMA data, i.e. plugin's type.
   class UMASender {
    public:
     virtual ~UMASender() {}
     virtual void SendPluginUMA(PluginType plugin_type) = 0;
   };
 
   // Returns singleton instance.
@@ skipping 23 matching lines @@
   // Converts plugin's mime type to plugin type.
   PluginType MimeTypeToPluginType(const std::string& mime_type);
 
   scoped_ptr<UMASender> report_sender_;
 
   DISALLOW_COPY_AND_ASSIGN(MissingPluginReporter);
 };
 
 #endif  // CHROME_RENDERER_PLUGINS_PLUGIN_UMA_H_