Report UMA for Shockwave Flash and Widevine CDM.

chrome/renderer/plugins/plugin_uma.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/plugins/plugin_uma.h"
 
 #include <algorithm>
 #include <cstring>
 
 #include "base/metrics/histogram.h"
 #include "base/string_util.h"
 
 namespace {
 
 // String we will use to convert mime tyoe to plugin type.
 const char kWindowsMediaPlayerType[] = "application/x-mplayer2";
 const char kSilverlightTypePrefix[] = "application/x-silverlight";
 const char kRealPlayerTypePrefix[] = "audio/x-pn-realaudio";
 const char kJavaTypeSubstring[] = "application/x-java-applet";
 const char kQuickTimeType[] = "video/quicktime";
+const char kShockwaveFlashType[] = "application/x-shockwave-flash";
+const char kWidevineCDMType[] = "application/x-ppapi-widevine-cdm";
 
 // Arrays containing file extensions connected with specific plugins.
 // The arrays must be sorted because binary search is used on them.
 const char* kWindowsMediaPlayerExtensions[] = {
     ".asx"
 };
 
 const char* kRealPlayerExtensions[] = {
     ".ra",
     ".ram",
@@ skipping 16 matching lines @@
 
 class UMASenderImpl : public MissingPluginReporter::UMASender {
   virtual void SendPluginUMA(MissingPluginReporter::PluginType plugin_type)
       OVERRIDE;
 };
 
 void UMASenderImpl::SendPluginUMA(
     MissingPluginReporter::PluginType plugin_type) {
   UMA_HISTOGRAM_ENUMERATION("Plugin.MissingPlugins",
                             plugin_type,
                             MissingPluginReporter::OTHER);

[ddorwin, 2013/04/04 20:08:26]

You need to use your new PLUGIN_TYPE_MAX here, right?

[xhwang, 2013/04/05 00:58:18]

Done.

 }
 
 // static.
 MissingPluginReporter* MissingPluginReporter::GetInstance() {
   return Singleton<MissingPluginReporter>::get();
 }
 
 void MissingPluginReporter::ReportPluginMissing(
     std::string plugin_mime_type, const GURL& plugin_src) {
   PluginType plugin_type;
@@ skipping 40 matching lines @@
   size_t last_dot = extension_file_path.find_last_of('.');
   if (last_dot != std::string::npos) {
     *extension = extension_file_path.substr(last_dot);
   } else {
     extension->clear();
   }
 
   StringToLowerASCII(extension);
 }
 
 MissingPluginReporter::PluginType MissingPluginReporter::SrcToPluginType(

[xhwang, 2013/04/03 23:36:55]

For flash, do we also want to get plugin type from extensions?

[xhwang, 2013/04/03 23:38:09]

+ilja

[yzshen1, 2013/04/04 17:38:11]

I think we could add the extensions for Flash here, right? It is more consistent
that way.

[ddorwin, 2013/04/04 19:52:24]

SGTM. Also, should we differentiate "OTHER" mime type from
"UNRECOGNIZED_EXTENSION"? Those are very different buckets.

[ddorwin, 2013/04/04 20:08:26]

Even better, (since the meaning of OTHER is/would change) we could deprecate the
middle-of-the-list OTHER and replace it with OTHER_MIME_TYPE=254 and
OTHER_FILE_EXTENSION=255.

[xhwang, 2013/04/05 00:58:18]

Done. Do we want to add more, e.g. fla et al?

[xhwang, 2013/04/05 00:58:18]

Done. Use 240/241 in case we want to add more unsupported types. But this really
doesn't matter as the limit is MAX_INT.

[ddorwin, 2013/04/05 04:21:37]

I coud be wrong, but it looks like we only support two:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/common/chro...

[xhwang, 2013/04/05 05:05:21]

Done.

     const GURL& src) {
   std::string file_extension;
   ExtractFileExtension(src, &file_extension);
   if (CStringArrayContainsCString(kWindowsMediaPlayerExtensions,
                                   arraysize(kWindowsMediaPlayerExtensions),
                                   file_extension.c_str())) {
     return WINDOWS_MEDIA_PLAYER;
   }
 
   if (CStringArrayContainsCString(kQuickTimeExtensions,
@@ skipping 23 matching lines @@
   prefix_length = strlen(kRealPlayerTypePrefix);
   if (strncmp(mime_type.c_str(), kRealPlayerTypePrefix, prefix_length) == 0)
     return REALPLAYER;
 
   if (strstr(mime_type.c_str(), kJavaTypeSubstring))
     return JAVA;
 
   if (strcmp(mime_type.c_str(), kQuickTimeType) == 0)
     return QUICKTIME;
 
+  if (strcmp(mime_type.c_str(), kShockwaveFlashType) == 0)
+    return SHOCKWAVE_FLASH;
+
+  if (strcmp(mime_type.c_str(), kWidevineCDMType) == 0)
+    return WIDEVINE_CDM;
+
   return OTHER;
 }
-