Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 1360083003: Tweak asserts for dominant-baseline in SVGTextLayoutEngineBaseline (Closed)

Created:
5 years, 3 months ago by fs
Modified:
5 years, 3 months ago
Reviewers:
pdr.
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tweak asserts for dominant-baseline in SVGTextLayoutEngineBaseline The 'no-change' and 'reset-size' dominant-baseline value will consult their parent to try and resolve a suitable value. If the parent has one of these values, the process will continue up the ancestor chain. When reaching the LayoutView however, we should encounter the initial value ('auto') and the search will end. Move the assertion for an existing parent down into the branches that handle the values 'no-change' and 'reset-size'. Also rewrap a comment and replace a FIXME with TODO. BUG=534796 Committed: https://crrev.com/f733f40a85ce65d38260d88f12f20752bba70bb8 Cr-Commit-Position: refs/heads/master@{#350612}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -4 lines) Patch
A third_party/WebKit/LayoutTests/svg/custom/dominant-baseline-propagation-crash.html View 1 chunk +12 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/svg/custom/dominant-baseline-propagation-crash-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngineBaseline.cpp View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fs
I noticed that these "problematic" values had been dropped from CSS Inline [1], so maybe ...
5 years, 3 months ago (2015-09-24 16:21:45 UTC) #2
pdr.
LGTM
5 years, 3 months ago (2015-09-24 17:55:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360083003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360083003/1
5 years, 3 months ago (2015-09-24 17:56:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-24 18:38:40 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 18:40:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f733f40a85ce65d38260d88f12f20752bba70bb8
Cr-Commit-Position: refs/heads/master@{#350612}

Powered by Google App Engine
This is Rietveld 408576698