Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Issue 1360063002: Include HTTP header bytes in GetTotalSent/ReceivedBytes for QUIC. (Closed)

Created:
5 years, 3 months ago by sclittle
Modified:
5 years, 3 months ago
Reviewers:
bengr, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Include HTTP header bytes in GetTotalSent/ReceivedBytes for QUIC. This change includes the size of the SPDY request/response header frames sent/received for a QuicHttpStream in QuicHttpStream.GetTotalSent/ReceivedBytes. BUG=518894 Committed: https://crrev.com/c4dc1a3ab9a0ff90ec68110c0c18688d98c63446 Cr-Commit-Position: refs/heads/master@{#350404}

Patch Set 1 : Initial patch set #

Total comments: 1

Patch Set 2 : Addressed nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -78 lines) Patch
M net/quic/quic_http_stream.h View 1 2 chunks +7 lines, -1 line 0 comments Download
M net/quic/quic_http_stream.cc View 1 4 chunks +25 lines, -13 lines 0 comments Download
M net/quic/quic_http_stream_test.cc View 20 chunks +99 lines, -50 lines 0 comments Download
M net/quic/quic_reliable_client_stream.h View 2 chunks +4 lines, -3 lines 0 comments Download
M net/quic/quic_reliable_client_stream.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M net/quic/quic_reliable_client_stream_test.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M net/quic/test_tools/quic_test_packet_maker.h View 2 chunks +27 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_packet_maker.cc View 3 chunks +32 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
sclittle
PTAL
5 years, 3 months ago (2015-09-23 01:48:01 UTC) #3
Ryan Hamilton
LGTM, module one tweak. https://codereview.chromium.org/1360063002/diff/20001/net/quic/quic_http_stream.h File net/quic/quic_http_stream.h (right): https://codereview.chromium.org/1360063002/diff/20001/net/quic/quic_http_stream.h#newcode151 net/quic/quic_http_stream.h:151: int64_t headers_stream_sent_bytes_; nit: I would ...
5 years, 3 months ago (2015-09-23 02:53:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360063002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360063002/40001
5 years, 3 months ago (2015-09-23 21:00:56 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/124666)
5 years, 3 months ago (2015-09-23 21:25:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360063002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360063002/40001
5 years, 3 months ago (2015-09-23 21:28:00 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/124685)
5 years, 3 months ago (2015-09-23 22:01:56 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360063002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360063002/40001
5 years, 3 months ago (2015-09-23 22:06:27 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/56687)
5 years, 3 months ago (2015-09-23 22:36:53 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360063002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360063002/40001
5 years, 3 months ago (2015-09-23 23:07:51 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 3 months ago (2015-09-24 00:15:53 UTC) #20
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 00:35:01 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c4dc1a3ab9a0ff90ec68110c0c18688d98c63446
Cr-Commit-Position: refs/heads/master@{#350404}

Powered by Google App Engine
This is Rietveld 408576698