Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(9)

Issue 1360043002: Web Animations: Don't set compositor pending when document has been detached (Closed)

Created:
3 years, 2 months ago by dstockwell
Modified:
3 years, 2 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, Eric Willigers, rjwright, shans
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Web Animations: Don't set compositor pending when document has been detached When there are multiple documents it is possible for an animation's timeline to become detached. The existing assertions were not valid in this case. BUG=492061 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202666

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M Source/core/animation/Animation.cpp View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
dstockwell
3 years, 2 months ago (2015-09-23 00:56:11 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360043002/1
3 years, 2 months ago (2015-09-23 00:56:33 UTC) #4
alancutter (OOO until 2018)
> When there were multiple documents it was possible for an animation's timeline to become ...
3 years, 2 months ago (2015-09-23 03:57:57 UTC) #5
alancutter (OOO until 2018)
lgtm
3 years, 2 months ago (2015-09-23 03:59:22 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/72451)
3 years, 2 months ago (2015-09-23 04:57:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360043002/1
3 years, 2 months ago (2015-09-23 05:20:07 UTC) #10
commit-bot: I haz the power
3 years, 2 months ago (2015-09-23 06:33:43 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202666

Powered by Google App Engine
This is Rietveld 408576698