Remove native_control* and some other non-Aura windows code

Remove native_control* and some other non-Aura windows code

Started by trying remove use of atlbase.h in native_control,
but since it's unused, just delete it all and a few places
where it was referenced in !USE_AURA blocks.

R=sky@chromium.org
BUG=5027, 330735
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247647

[sky, 2014-01-29 04:06:20]

Nice, LGTM

https://codereview.chromium.org/136003015/diff/1/ui/views/win/hwnd_message_ha...
File ui/views/win/hwnd_message_handler.h (right):

https://codereview.chromium.org/136003015/diff/1/ui/views/win/hwnd_message_ha...
ui/views/win/hwnd_message_handler.h:20: #include
"base/message_loop/message_loop.h"
I suspect you can remove this include now.

[beng (no_code_reviews), 2014-01-29 04:12:16]

Hey Scott, have you submitted many other CLs like this? Do you have links?
It'd be interesting to quantify the size of code reduction we're taking by
removing all of this.

-Ben


On Tue, Jan 28, 2014 at 4:26 PM, <scottmg@chromium.org> wrote:

> Reviewers: sky,
>
> Description:
> Remove native_control* and some other non-Aura windows code
>
> Started by trying remove use of atlbase.h in native_control,
> but since it's unused, just delete it all and a few places
> where it was referenced in !USE_AURA blocks.
>
> R=sky@chromium.org
> BUG=5027,330735
>
> Please review this at https://codereview.chromium.org/136003015/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files (+1, -2254 lines):
>   D ui/views/controls/native_control.h
>   D ui/views/controls/native_control.cc
>   D ui/views/controls/native_control_win.h
>   D ui/views/controls/native_control_win.cc
>   D ui/views/widget/native_widget_win.h
>   D ui/views/widget/native_widget_win.cc
>   M chrome/browser/ui/views/frame/browser_view.cc
>   M ui/views/views.gyp
>   M ui/views/win/hwnd_message_handler.h
>   M ui/views/win/hwnd_message_handler.cc
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[beng (no_code_reviews), 2014-01-29 04:13:32]

Nevermind I found https://code.google.com/p/chromium/issues/detail?id=330735


On Tue, Jan 28, 2014 at 8:12 PM, Ben Goodger <beng@google.com> wrote:

> Hey Scott, have you submitted many other CLs like this? Do you have links?
> It'd be interesting to quantify the size of code reduction we're taking by
> removing all of this.
>
> -Ben
>
>
> On Tue, Jan 28, 2014 at 4:26 PM, <scottmg@chromium.org> wrote:
>
>> Reviewers: sky,
>>
>> Description:
>> Remove native_control* and some other non-Aura windows code
>>
>> Started by trying remove use of atlbase.h in native_control,
>> but since it's unused, just delete it all and a few places
>> where it was referenced in !USE_AURA blocks.
>>
>> R=sky@chromium.org
>> BUG=5027,330735
>>
>> Please review this at https://codereview.chromium.org/136003015/
>>
>> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>>
>> Affected files (+1, -2254 lines):
>>   D ui/views/controls/native_control.h
>>   D ui/views/controls/native_control.cc
>>   D ui/views/controls/native_control_win.h
>>   D ui/views/controls/native_control_win.cc
>>   D ui/views/widget/native_widget_win.h
>>   D ui/views/widget/native_widget_win.cc
>>   M chrome/browser/ui/views/frame/browser_view.cc
>>   M ui/views/views.gyp
>>   M ui/views/win/hwnd_message_handler.h
>>   M ui/views/win/hwnd_message_handler.cc
>>
>>
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[scottmg, 2014-01-29 05:10:23]

There's also https://code.google.com/p/chromium/issues/detail?id=319122which'll
probably get a bunch of CLs.


On Tue, Jan 28, 2014 at 8:13 PM, Ben Goodger <beng@google.com> wrote:

> Nevermind I found
> https://code.google.com/p/chromium/issues/detail?id=330735
>
>
> On Tue, Jan 28, 2014 at 8:12 PM, Ben Goodger <beng@google.com> wrote:
>
>> Hey Scott, have you submitted many other CLs like this? Do you have
>> links? It'd be interesting to quantify the size of code reduction we're
>> taking by removing all of this.
>>
>> -Ben
>>
>>
>> On Tue, Jan 28, 2014 at 4:26 PM, <scottmg@chromium.org> wrote:
>>
>>> Reviewers: sky,
>>>
>>> Description:
>>> Remove native_control* and some other non-Aura windows code
>>>
>>> Started by trying remove use of atlbase.h in native_control,
>>> but since it's unused, just delete it all and a few places
>>> where it was referenced in !USE_AURA blocks.
>>>
>>> R=sky@chromium.org
>>> BUG=5027,330735
>>>
>>> Please review this at https://codereview.chromium.org/136003015/
>>>
>>> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>>>
>>> Affected files (+1, -2254 lines):
>>>   D ui/views/controls/native_control.h
>>>   D ui/views/controls/native_control.cc
>>>   D ui/views/controls/native_control_win.h
>>>   D ui/views/controls/native_control_win.cc
>>>   D ui/views/widget/native_widget_win.h
>>>   D ui/views/widget/native_widget_win.cc
>>>   M chrome/browser/ui/views/frame/browser_view.cc
>>>   M ui/views/views.gyp
>>>   M ui/views/win/hwnd_message_handler.h
>>>   M ui/views/win/hwnd_message_handler.cc
>>>
>>>
>>>
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[scottmg, 2014-01-29 06:27:53]

https://codereview.chromium.org/136003015/diff/1/ui/views/win/hwnd_message_ha...
File ui/views/win/hwnd_message_handler.h (right):

https://codereview.chromium.org/136003015/diff/1/ui/views/win/hwnd_message_ha...
ui/views/win/hwnd_message_handler.h:20: #include
"base/message_loop/message_loop.h"
On 2014/01/29 04:06:20, sky wrote:
> I suspect you can remove this include now.

Done.

[scottmg, 2014-01-29 06:28:22]

Committed patchset #2 manually as r247647 (presubmit successful).