Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 136003013: PasswordAutofillAgentTest.InlineAutocomplete depends on details of style recalc timing (Closed)

Created:
6 years, 10 months ago by abarth-chromium
Modified:
6 years, 10 months ago
Reviewers:
Garrett Casto
CC:
chromium-reviews, benquan, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

PasswordAutofillAgentTest.InlineAutocomplete depends on details of style recalc timing This CL fixes an incorrect assumption in PasswordAutofillAgentTest.InlineAutocomplete. Previously, this code assumed that one trip through the event loop was sufficient to ensure that style was recalcuated. After we move recalc style to be triggered by requestAnimationFrame, this assumption will no longer be valid. This CL changes the test to explicitly recalc style by calling WebView::layout. Unfortunately, we cannot simply call WebView::layout in straight-line code because this test does some of its work off the event loop. Instead, we need to schedule the call to layout after we schedule the other async work. BUG=337617 R=gcasto@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247590

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M chrome/renderer/autofill/password_autofill_agent_browsertest.cc View 1 chunk +14 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
abarth-chromium
6 years, 10 months ago (2014-01-28 20:45:49 UTC) #1
Evan Stade
+gcasto, -estade
6 years, 10 months ago (2014-01-28 22:11:09 UTC) #2
Garrett Casto
lgtm
6 years, 10 months ago (2014-01-28 23:13:01 UTC) #3
abarth-chromium
On 2014/01/28 23:13:01, Garrett Casto wrote: > lgtm Thanks!
6 years, 10 months ago (2014-01-28 23:35:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/136003013/1
6 years, 10 months ago (2014-01-28 23:37:26 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-01-29 02:15:26 UTC) #6
Message was sent while issue was closed.
Change committed as 247590

Powered by Google App Engine
This is Rietveld 408576698