src/runtime.cc - Issue 136003003: Closed generator returns a completed object instead of throwing a error

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.cc

Issue 136003003: Closed generator returns a completed object instead of throwing a error (Closed) Base URL: git://github.com/v8/v8.git@master

Patch Set: Rev 2 Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime.cc

diff --git a/src/runtime.cc b/src/runtime.cc

index 7a2d46c4b4315a96ad86ef7cb8c79458fef66b9b..846cdbc685f52de3c8c6fe9cdbf1dc79a911395c 100644

--- a/src/runtime.cc

+++ b/src/runtime.cc

@@ -3116,8 +3116,8 @@ RUNTIME_FUNCTION(MaybeObject*, Runtime_ResumeJSGeneratorObject) {

ASSERT_EQ(frame->function(), generator_object->function());

ASSERT(frame->function()->is_compiled());

- STATIC_ASSERT(JSGeneratorObject::kGeneratorExecuting <= 0);

- STATIC_ASSERT(JSGeneratorObject::kGeneratorClosed <= 0);

+ STATIC_ASSERT(JSGeneratorObject::kGeneratorExecuting < 0);

+ STATIC_ASSERT(JSGeneratorObject::kGeneratorClosed == 0);

Address pc = generator_object->function()->code()->instruction_start();

int offset = generator_object->continuation();