third_party/WebKit/Source/modules/permissions/PermissionsCallback.h - Issue 1360023005: permissions: remove duplicates from request multiple at the Blink level

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/permissions/PermissionsCallback.h

Issue 1360023005: permissions: remove duplicates from request multiple at the Blink level (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor-permissions

Patch Set: Rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/permissions/Permissions.cpp ('k') | third_party/WebKit/Source/modules/permissions/PermissionsCallback.cpp » ('j') | third_party/WebKit/Source/modules/permissions/PermissionsCallback.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/permissions/PermissionsCallback.h

diff --git a/third_party/WebKit/Source/modules/permissions/PermissionsCallback.h b/third_party/WebKit/Source/modules/permissions/PermissionsCallback.h

index feef2872bb09a55814d50f4825eef681094489fe..c9127d410a12020baa7fa40beb76221c47257cf9 100644

--- a/third_party/WebKit/Source/modules/permissions/PermissionsCallback.h

+++ b/third_party/WebKit/Source/modules/permissions/PermissionsCallback.h

@@ -26,7 +26,7 @@ class ScriptPromiseResolver;

class PermissionsCallback final

: public WebCallbacks<WebPassOwnPtr<WebVector<WebPermissionStatus>>, void> {

public:

- PermissionsCallback(ScriptPromiseResolver*, PassOwnPtr<WebVector<WebPermissionType>>);

+ PermissionsCallback(ScriptPromiseResolver*, PassOwnPtr<Vector<WebPermissionType>>, PassOwnPtr<Vector<int>>);

~PermissionsCallback() = default;

void onSuccess(WebPassOwnPtr<WebVector<WebPermissionStatus>>) override;

@@ -34,7 +34,8 @@ public:

private:

Persistent<ScriptPromiseResolver> m_resolver;

- OwnPtr<WebVector<WebPermissionType>> m_permissionTypes;

+ OwnPtr<Vector<WebPermissionType>> m_requestedPermissions;

+ OwnPtr<Vector<int>> m_indexToCannonicalIndex;

mlamouri (slow - plz ping) 2015/09/29 13:25:35 The name is confusing. Could you use "caller index

Lalit Maganti 2015/09/29 14:51:50 Done.

WTF_MAKE_NONCOPYABLE(PermissionsCallback);

};