Issue 1359993002: Fix code checking arguments to an intrinsic call.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1359993002: Fix code checking arguments to an intrinsic call. (Closed)

Created:
5 years, 3 months ago by Karl

Modified:
5 years, 3 months ago

Reviewers:
Jim Stichnoth, John

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix code checking arguments to an intrinsic call. Fixes instrinsic function "validateCall" to properly define which parameter type doesn't match the expected signature for that intrinsic. Previous code did not take into account that the first element of the intrinsic signature was the return type. Also fixes error messages to print the name of the intrinsic function. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4326 R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=958ff342c2bfd6e6ffaed7c44e170405ae1245d2

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -6 lines)			Patch
M	src/IceIntrinsics.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/PNaClTranslator.cpp	View	1	4 chunks	+9 lines, -5 lines	0 comments	Download
A	tests_lit/parse_errs/Inputs/bad-intrinsic-arg.tbc	View		1 chunk	+30 lines, -0 lines	0 comments	Download
A	tests_lit/parse_errs/bad-intrinsic-arg.test	View		1 chunk	+28 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Karl

5 years, 3 months ago (2015-09-22 21:09:10 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
958ff342c2bfd6e6ffaed7c44e170405ae1245d2 (presubmit successful).