Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1359973003: Support tracing flow events v2 in Blink (Closed)

Created:
5 years, 3 months ago by oystein (OOO til 10th of July)
Modified:
5 years, 2 months ago
Reviewers:
tkent
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support tracing flow events v2 in Blink This includes passing an additional bindId parameter to Chrome, and increasing the size of the flags field from char to int (it's been an int in Chrome for some time). Prerequisite (Chrome side CL) is https://codereview.chromium.org/1354453002/ Original review URL: https://codereview.chromium.org/1347113004/ TBR=tkent@chromium.org BUG=532726 Committed: https://crrev.com/73dd7bd7dfda7e1bf190f10ad6718a662207697d Cr-Commit-Position: refs/heads/master@{#350606}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -41 lines) Patch
M third_party/WebKit/Source/platform/EventTracer.h View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/EventTracer.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/TraceEvent.h View 12 chunks +57 lines, -32 lines 0 comments Download
M third_party/WebKit/public/platform/Platform.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1359973003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1359973003/1
5 years, 3 months ago (2015-09-24 00:24:25 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/117256)
5 years, 3 months ago (2015-09-24 01:44:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1359973003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1359973003/1
5 years, 2 months ago (2015-09-24 17:21:52 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-24 18:12:04 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/73dd7bd7dfda7e1bf190f10ad6718a662207697d Cr-Commit-Position: refs/heads/master@{#350606}
5 years, 2 months ago (2015-09-24 18:13:14 UTC) #8
tkent
5 years, 2 months ago (2015-10-07 00:35:19 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698