Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1359943003: SkPDF: add basic metadata support (Closed)

Created:
5 years, 3 months ago by hal.canary
Modified:
5 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPDF: add basic metadata support Motivation: I want too finalize this API before working on the more complex problem of adding XMP metadata for PDF/A. BUG=skia:3110 Committed: https://skia.googlesource.com/skia/+/f12a1673f024d30d30f06b9f88b5cc072b8a2d1e

Patch Set 1 #

Patch Set 2 : unit test #

Patch Set 3 : unused parameter #

Total comments: 2

Patch Set 4 : style change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -3 lines) Patch
M dm/DMSrcSink.cpp View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M include/core/SkDocument.h View 1 2 3 2 chunks +29 lines, -0 lines 0 comments Download
M include/core/SkTArray.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/doc/SkDocument_PDF.cpp View 1 2 3 8 chunks +67 lines, -3 lines 0 comments Download
A tests/PDFMetadataAttributeTest.cpp View 1 1 chunk +52 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (9 generated)
hal.canary
reed@: Please take a look at the API. bungeman@: Please look at emplace_back impl. tomhudson@ ...
5 years, 3 months ago (2015-09-22 19:39:01 UTC) #2
bungeman-skia
> bungeman@: Please look at emplace_back impl. Yay, perfect forwarding. SkTArray impl lgtm.
5 years, 3 months ago (2015-09-22 20:12:11 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1359943003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1359943003/20001
5 years, 3 months ago (2015-09-22 20:13:27 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86_64-Release-Trybot/builds/3385)
5 years, 3 months ago (2015-09-22 20:14:36 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1359943003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1359943003/40001
5 years, 3 months ago (2015-09-22 20:17:12 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-22 20:24:20 UTC) #11
reed1
https://codereview.chromium.org/1359943003/diff/40001/include/core/SkDocument.h File include/core/SkDocument.h (right): https://codereview.chromium.org/1359943003/diff/40001/include/core/SkDocument.h#newcode129 include/core/SkDocument.h:129: SkString key, value; following skia fNaming fConvention?
5 years, 3 months ago (2015-09-23 10:14:47 UTC) #12
hal.canary
https://codereview.chromium.org/1359943003/diff/40001/include/core/SkDocument.h File include/core/SkDocument.h (right): https://codereview.chromium.org/1359943003/diff/40001/include/core/SkDocument.h#newcode129 include/core/SkDocument.h:129: SkString key, value; On 2015/09/23 10:14:47, reed1 wrote: > ...
5 years, 3 months ago (2015-09-23 12:42:43 UTC) #13
tomhudson
lgtm
5 years, 3 months ago (2015-09-23 14:25:22 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1359943003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1359943003/60001
5 years, 3 months ago (2015-09-23 14:25:40 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/2821)
5 years, 3 months ago (2015-09-23 14:26:41 UTC) #19
reed1
api lgtm
5 years, 3 months ago (2015-09-23 14:33:40 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1359943003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1359943003/60001
5 years, 3 months ago (2015-09-23 19:45:17 UTC) #22
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 19:45:53 UTC) #23
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/f12a1673f024d30d30f06b9f88b5cc072b8a2d1e

Powered by Google App Engine
This is Rietveld 408576698