Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Issue 135993003: Cleanup: Remove unused IDR entries from build/ios/grit_whitelist.txt. (Closed)

Created:
6 years, 11 months ago by Lei Zhang
Modified:
6 years, 9 months ago
Reviewers:
droger, stuartmorgan
CC:
chromium-reviews
Visibility:
Public.

Description

Cleanup: Remove unused IDR entries from build/ios/grit_whitelist.txt. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245078

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M build/ios/grit_whitelist.txt View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Lei Zhang
IDR_NET_INTERNALS_INDEX_* only exist internally IDR_UPDATE_MENU4 DNE.
6 years, 11 months ago (2014-01-14 21:44:19 UTC) #1
stuartmorgan
lgtm
6 years, 11 months ago (2014-01-14 22:46:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/135993003/20001
6 years, 11 months ago (2014-01-15 02:50:32 UTC) #3
commit-bot: I haz the power
Change committed as 245078
6 years, 11 months ago (2014-01-16 02:51:09 UTC) #4
droger
These resources are needed downstream (at least temporarily). Should we add them back here or ...
6 years, 9 months ago (2014-03-18 15:15:15 UTC) #5
droger
On 2014/03/18 15:15:15, droger wrote: > These resources are needed downstream (at least temporarily). > ...
6 years, 9 months ago (2014-03-18 15:15:39 UTC) #6
stuartmorgan
6 years, 9 months ago (2014-03-18 15:26:00 UTC) #7
Message was sent while issue was closed.
On 2014/03/18 15:15:39, droger wrote:
> On 2014/03/18 15:15:15, droger wrote:
> > These resources are needed downstream (at least temporarily).
> > Should we add them back here or downstream only?
> 
> Actually, only IDR_NET_INTERNALS_INDEX_HTML and IDR_NET_INTERNALS_INDEX_JS are
> needed.

Either is fine; at this point the files get out of sync so regularly it's not
clear it's worth worrying about. Eventually componentization will handle this,
so I'm not worried too much about deciding what the "right" solution is.

Powered by Google App Engine
This is Rietveld 408576698