Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 1359923002: Require that the module symbol table can't appear after function. (Closed)

Created:
5 years, 3 months ago by Karl
Modified:
5 years, 3 months ago
Reviewers:
Jim Stichnoth, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Require that the module symbol table can't appear after function. The bitcode parser assumes that the module symbol table, if it exists, must appear before the first function block (i.e. defininition). However, the parser did not check this constraint. This patch fixes that omission. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4320 R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=28fc2d7dce3693b40d2a99d84d4147274d66784c

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -6 lines) Patch
M src/PNaClTranslator.cpp View 1 1 chunk +6 lines, -0 lines 0 comments Download
A + tests_lit/parse_errs/Inputs/symtab-after-fcn.tbc View 1 chunk +3 lines, -6 lines 0 comments Download
A tests_lit/parse_errs/symtab-after-fcn.test View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Karl
5 years, 3 months ago (2015-09-22 18:34:56 UTC) #2
Jim Stichnoth
lgtm https://codereview.chromium.org/1359923002/diff/1/src/PNaClTranslator.cpp File src/PNaClTranslator.cpp (right): https://codereview.chromium.org/1359923002/diff/1/src/PNaClTranslator.cpp#newcode3161 src/PNaClTranslator.cpp:3161: // If we have already processed a function ...
5 years, 3 months ago (2015-09-22 20:06:06 UTC) #3
Karl
Committed patchset #2 (id:20001) manually as 28fc2d7dce3693b40d2a99d84d4147274d66784c (presubmit successful).
5 years, 3 months ago (2015-09-22 20:14:58 UTC) #4
Karl
5 years, 3 months ago (2015-09-22 20:15:15 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/1359923002/diff/1/src/PNaClTranslator.cpp
File src/PNaClTranslator.cpp (right):

https://codereview.chromium.org/1359923002/diff/1/src/PNaClTranslator.cpp#new...
src/PNaClTranslator.cpp:3161: // If we have already processed a function block
(i.e.  we have already
On 2015/09/22 20:06:06, stichnot wrote:
> single space after i.e.

Done.

Powered by Google App Engine
This is Rietveld 408576698