Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1016)

Issue 13599006: [MediaStream API] Allow empty MediaStreams (Closed)

Created:
7 years, 8 months ago by Tommy Widenflycht
Modified:
7 years, 8 months ago
Reviewers:
Li Yin, abarth-chromium
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[MediaStream API] Allow empty MediaStreams The spec is a bit unclear ecactly what should happen with newly created MediaStreams that doesn't have any tracks. The current implementation is too strict and the spec is being worked upon to be clearer. In the meantime this patch doesn't set eneded to true in the constructor. R=abarth@chromium.org,li.yin@intel.com BUG=229350 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=147925

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -31 lines) Patch
M LayoutTests/fast/mediastream/MediaStreamConstructor.html View 3 chunks +12 lines, -17 lines 0 comments Download
M LayoutTests/fast/mediastream/MediaStreamConstructor-expected.txt View 11 chunks +0 lines, -11 lines 0 comments Download
M Source/WebCore/platform/mediastream/MediaStreamDescriptor.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Tommy Widenflycht
7 years, 8 months ago (2013-04-08 12:55:28 UTC) #1
abarth-chromium
lgtm
7 years, 8 months ago (2013-04-08 16:44:30 UTC) #2
Li Yin
On 2013/04/08 16:44:30, abarth wrote: > lgtm Yes, the spec has no introduction about empty ...
7 years, 8 months ago (2013-04-09 01:19:27 UTC) #3
Tommy Widenflycht
Yeah, it's not completely symmetrical but a bug has been filed against the spec to ...
7 years, 8 months ago (2013-04-09 07:40:46 UTC) #4
Tommy Widenflycht
7 years, 8 months ago (2013-04-09 13:16:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r147925 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698