Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Issue 1359853002: Small cleanups to SkSmallAllocator (Closed)

Created:
5 years, 3 months ago by mdempsky
Modified:
5 years, 3 months ago
Reviewers:
mtklein, mtklein_C
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Small cleanups to SkSmallAllocator - Add missing #include <new>. - Simplify createT functions with C++11 variadic templates. - Change destroyT helper function into a private static function. Committed: https://skia.googlesource.com/skia/+/78041fab416f5e92019f632dc64507c8ede43eab

Patch Set 1 #

Patch Set 2 : Remove vestigial comment #

Total comments: 2

Patch Set 3 : s/destroyT/DestroyT/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -51 lines) Patch
M src/core/SkSmallAllocator.h View 1 2 4 chunks +11 lines, -51 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1359853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1359853002/1
5 years, 3 months ago (2015-09-22 15:15:23 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 3 months ago (2015-09-22 15:15:24 UTC) #3
mdempsky
5 years, 3 months ago (2015-09-22 15:33:46 UTC) #5
mtklein
https://codereview.chromium.org/1359853002/diff/20001/src/core/SkSmallAllocator.h File src/core/SkSmallAllocator.h (right): https://codereview.chromium.org/1359853002/diff/20001/src/core/SkSmallAllocator.h#newcode124 src/core/SkSmallAllocator.h:124: static void destroyT(void* ptr) { Let's rename it DestroyT ...
5 years, 3 months ago (2015-09-22 16:03:41 UTC) #7
mdempsky
https://codereview.chromium.org/1359853002/diff/20001/src/core/SkSmallAllocator.h File src/core/SkSmallAllocator.h (right): https://codereview.chromium.org/1359853002/diff/20001/src/core/SkSmallAllocator.h#newcode124 src/core/SkSmallAllocator.h:124: static void destroyT(void* ptr) { On 2015/09/22 16:03:41, mtklein ...
5 years, 3 months ago (2015-09-22 16:15:21 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1359853002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1359853002/40001
5 years, 3 months ago (2015-09-22 16:22:39 UTC) #10
mtklein
lgtm
5 years, 3 months ago (2015-09-22 17:31:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1359853002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1359853002/40001
5 years, 3 months ago (2015-09-22 17:32:16 UTC) #14
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 17:37:10 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/78041fab416f5e92019f632dc64507c8ede43eab

Powered by Google App Engine
This is Rietveld 408576698