Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Unified Diff: tests/StringTest.cpp

Issue 1359833005: fix DM? (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: fuse Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dm/DM.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/StringTest.cpp
diff --git a/tests/StringTest.cpp b/tests/StringTest.cpp
index 595a0b194a93fe963e1cc56ce3ed6253d2794b3f..f621dc96aff6c56f080351623b50b02bed1f08ca 100644
--- a/tests/StringTest.cpp
+++ b/tests/StringTest.cpp
@@ -156,7 +156,7 @@ DEF_TEST(String, reporter) {
{ SK_Scalar1, "1" },
{ -SK_Scalar1, "-1" },
{ SK_Scalar1/2, "0.5" },
- #if defined(SK_BUILD_FOR_WIN) && (_MSC_VER < 1900)
+ #if defined(SK_BUILD_FOR_WIN) && (_MSC_VER < 1900)
{ 3.4028234e38f, "3.4028235e+038" },
{ -3.4028234e38f, "-3.4028235e+038" },
#else
@@ -198,4 +198,12 @@ DEF_TEST(String_SkStrSplit, r) {
REPORTER_ASSERT(r, results[3].equals("dee"));
REPORTER_ASSERT(r, results[4].equals("f"));
REPORTER_ASSERT(r, results[5].equals("g"));
+
+ results.reset();
+ SkStrSplit("\n", "\n", &results);
+ REPORTER_ASSERT(r, results.count() == 1);
+
+ results.reset();
+ SkStrSplit("", "\n", &results);
+ REPORTER_ASSERT(r, results.count() == 0);
}
« no previous file with comments | « dm/DM.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698