Issue 13598037: Add helper function for SPDY 4

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13598037: Add helper function for SPDY 4 (Closed)

Created:
7 years, 8 months ago by akalin

Modified:
7 years, 8 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add helper function for SPDY 4 This lands server change 44568667. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192885

Patch Set 1 #

Total comments: 1

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	net/spdy/spdy_framer.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	net/spdy/spdy_framer.cc	View		1 chunk	+7 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

lgtm https://codereview.chromium.org/13598037/diff/1/net/spdy/spdy_framer.cc File net/spdy/spdy_framer.cc (right): https://codereview.chromium.org/13598037/diff/1/net/spdy/spdy_framer.cc#newcode258 net/spdy/spdy_framer.cc:258: return 0xffffff - GetDataFrameMinimumSize(); I really think these ...

7 years, 8 months ago (2013-04-08 16:11:45 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/13598037/1

7 years, 8 months ago (2013-04-08 19:58:02 UTC) #3

akalin

7 years, 8 months ago (2013-04-08 20:48:51 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r192885 (presubmit successful).

Expand Messages | Collapse Messages