Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 13598016: Revert 192563 "Fix DownloadExtensionTest_OnDeterminingFilename_I..." (Closed)

Created:
7 years, 8 months ago by xhwang
Modified:
7 years, 8 months ago
Reviewers:
benjhayden
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 192563 "Fix DownloadExtensionTest_OnDeterminingFilename_I..." This test failed on Vista Tests bot: http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20(2)/builds/33887/steps/browser_tests/logs/DownloadExtensionTest_OnDeterminingFilename_InterruptedResume DownloadExtensionTest.DownloadExtensionTest_OnDeterminingFilename_InterruptedResume: [0405/091818:ERROR:gl_surface_egl.cc(98)] eglInitialize failed with error UNKNOWN [0405/091818:ERROR:gl_surface_win.cc(54)] GLSurfaceEGL::InitializeOneOff failed. HTTP server started on 127.0.0.1:51868... sending server_data: {"host": "127.0.0.1", "port": 51868} (36 bytes) browser\extensions\api\downloads\downloads_api_unittest.cc(3222): error: Value of: item->GetState() Actual: 0 Expected: DownloadItem::INTERRUPTED Which is: 3 browser\extensions\api\downloads\downloads_api_unittest.cc(3223): error: Value of: item->IsInterrupted() Actual: false Expected: true > Fix DownloadExtensionTest_OnDeterminingFilename_InterruptedResume > > Review URL: https://codereview.chromium.org/12422012 TBR=benjhayden@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192579

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -121 lines) Patch
M trunk/src/chrome/browser/extensions/api/downloads/downloads_api_unittest.cc View 4 chunks +66 lines, -121 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
xhwang
7 years, 8 months ago (2013-04-05 16:31:09 UTC) #1
xhwang
Committed patchset #1 manually as r192579.
7 years, 8 months ago (2013-04-05 16:31:33 UTC) #2
benjhayden
7 years, 8 months ago (2013-04-05 17:03:56 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698