Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(28)

Issue 13598005: Merge 147314 "Web Inspector: Fixed DOM Breakpoint pane styles." (Closed)

Created:
7 years, 6 months ago by apavlov
Modified:
7 years, 6 months ago
Reviewers:
commit-queue
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1453/
Visibility:
Public.

Description

Merge 147314 "Web Inspector: Fixed DOM Breakpoint pane styles." > Web Inspector: Fixed DOM Breakpoint pane styles. > https://bugs.webkit.org/show_bug.cgi?id=113688 > > Patch by Vladislav Kaznacheev <kaznacheev@chromium.org>; on 2013-04-01 > Reviewed by Pavel Feldman. > > The required stylesheet (breakpointsList.css) was not loaded because of > the peculiar way DOMBreakpointsSidebarPane is included in two panels > (Sources and Elements) via a proxy pane. Since DOMBreakpointsSidebarPane > was never shown directly the registerRequiredCSS call in its base class > NativeBreakpointsSidebarPane constructor had no effect. > Addin a registerRequiredCSS call to the proxy pane constructor fixes the > problem. > > * inspector/front-end/DOMBreakpointsSidebarPane.js: > (WebInspector.DOMBreakpointsSidebarPane.Proxy): TBR=commit-queue@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147735

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M Source/WebCore/inspector/front-end/DOMBreakpointsSidebarPane.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
apavlov
7 years, 6 months ago (2013-04-05 10:12:17 UTC) #1
apavlov
7 years, 6 months ago (2013-04-05 10:12:49 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r147735.

Powered by Google App Engine
This is Rietveld 408576698