Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1359733002: Make mutex semaphore based. (Closed)

Created:
5 years, 3 months ago by herb_g
Modified:
5 years, 3 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make mutex semaphore based. This implementation improves performance of SkMutex acquire / release pair from 42ns -> 13 ns. SkSharedMutex and SkSpinlock have the same performance. It also removes specialized windows and linux/mac code. BUG=skia: Committed: https://skia.googlesource.com/skia/+/7f0a3d7523377097184309152f883f1fcb12a4b8

Patch Set 1 #

Patch Set 2 : first real attempt #

Patch Set 3 : Fix constant problem #

Patch Set 4 : fix more compiler problems #

Patch Set 5 : fix mutex leak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -285 lines) Patch
M gyp/ports.gyp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M gyp/tools.gyp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M include/core/SkMutex.h View 1 2 3 4 2 chunks +63 lines, -7 lines 0 comments Download
D include/ports/SkMutex_pthread.h View 1 1 chunk +0 lines, -96 lines 0 comments Download
D include/ports/SkMutex_win.h View 1 1 chunk +0 lines, -79 lines 0 comments Download
M include/private/SkOncePtr.h View 1 2 4 chunks +8 lines, -9 lines 0 comments Download
A + include/private/SkSemaphore.h View 1 2 3 4 2 chunks +50 lines, -19 lines 0 comments Download
M src/core/SkSemaphore.h View 1 2 3 1 chunk +0 lines, -55 lines 0 comments Download
M src/core/SkSemaphore.cpp View 1 2 3 4 5 chunks +28 lines, -15 lines 0 comments Download
M src/core/SkSharedMutex.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 30 (15 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1359733002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1359733002/20001
5 years, 3 months ago (2015-09-22 21:23:10 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/3389)
5 years, 3 months ago (2015-09-22 21:24:05 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1359733002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1359733002/40001
5 years, 3 months ago (2015-09-22 21:36:24 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot/builds/3381) Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on ...
5 years, 3 months ago (2015-09-22 21:37:29 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1359733002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1359733002/60001
5 years, 3 months ago (2015-09-23 15:24:27 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1359733002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1359733002/80001
5 years, 3 months ago (2015-09-23 18:58:22 UTC) #13
herb_g
5 years, 3 months ago (2015-09-23 19:22:44 UTC) #16
mtklein
lgtm
5 years, 3 months ago (2015-09-24 07:19:49 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1359733002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1359733002/80001
5 years, 3 months ago (2015-09-24 14:00:04 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/2847)
5 years, 3 months ago (2015-09-24 14:01:22 UTC) #21
herb_g
Mike, can you rubber stamp this? There is no API change.
5 years, 3 months ago (2015-09-24 14:04:11 UTC) #22
reed1
lgtm
5 years, 3 months ago (2015-09-24 14:17:29 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1359733002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1359733002/80001
5 years, 3 months ago (2015-09-24 14:33:47 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1359733002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1359733002/80001
5 years, 3 months ago (2015-09-24 14:34:40 UTC) #29
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 14:34:55 UTC) #30
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/7f0a3d7523377097184309152f883f1fcb12a4b8

Powered by Google App Engine
This is Rietveld 408576698