chrome/browser/resources/file_manager/foreground/js/photo/gallery.js - Issue 135973012: [Galley] Fix an exception in clicking a thumbnail

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/file_manager/foreground/js/photo/gallery.js

Issue 135973012: [Galley] Fix an exception in clicking a thumbnail (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix the root cause Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/file_manager/foreground/js/photo/gallery.js

diff --git a/chrome/browser/resources/file_manager/foreground/js/photo/gallery.js b/chrome/browser/resources/file_manager/foreground/js/photo/gallery.js

index a95b9c71a11bdde76e2a49d4fd48f1f82f25ed77..cc99f7b183d38a7f6264fe58213c926f238d321b 100644

--- a/chrome/browser/resources/file_manager/foreground/js/photo/gallery.js

+++ b/chrome/browser/resources/file_manager/foreground/js/photo/gallery.js

@@ -637,13 +637,13 @@ Gallery.prototype.onKeyDown_ = function(event) {

* @private

Gallery.prototype.updateSelectionAndState_ = function() {

- var numSelectedItems = this.selectionModel_.length;

+ var selectedIndex = this.selectionModel_.selectedIndex;

+ var numSelectedItems = selectedIndex.length;

hirono 2014/02/13 06:42:22 this.selectedIndexes.length?

hirono 2014/02/13 06:43:26 No, this.selectionModel_.selectedIndexes.length?

var displayName = '';

var selectedEntryURL = null;

// If it's selecting something, update the variable values.

if (numSelectedItems) {

- var selectedIndex = this.selectionModel_.selectedIndex;

var selectedItem =

this.dataModel_.item(this.selectionModel_.selectedIndex);

this.selectedEntry_ = selectedItem.getEntry();

« no previous file with comments | « no previous file | no next file » | no next file with comments »