chrome/browser/resources/file_manager/foreground/js/photo/ribbon.js - Issue 135973012: [Galley] Fix an exception in clicking a thumbnail

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/file_manager/foreground/js/photo/ribbon.js

Issue 135973012: [Galley] Fix an exception in clicking a thumbnail (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/file_manager/foreground/js/photo/ribbon.js

diff --git a/chrome/browser/resources/file_manager/foreground/js/photo/ribbon.js b/chrome/browser/resources/file_manager/foreground/js/photo/ribbon.js

index 210c041898ac6cb8988533c5543289cab69d7644..0065e02772bcf126c5fa0005f6326cbb8fb6a1fd 100644

--- a/chrome/browser/resources/file_manager/foreground/js/photo/ribbon.js

+++ b/chrome/browser/resources/file_manager/foreground/js/photo/ribbon.js

@@ -305,8 +305,10 @@ Ribbon.prototype.renderThumbnail_ = function(index) {

thumbnail.className = 'ribbon-image';

thumbnail.addEventListener('click', function() {

var index = this.dataModel_.indexOf(item);

+ this.selectionModel_.beginChange();

hirono 2014/02/13 04:57:07 I'm not sure why the pair of methods fix the excep

this.selectionModel_.unselectAll();

this.selectionModel_.setIndexSelected(index, true);

+ this.selectionModel_.endChange();

}.bind(this));

util.createChild(thumbnail, 'image-wrapper');

« no previous file with comments | « no previous file | no next file » | no next file with comments »