[Galley] Fix an exception in clicking a thumbnail

[Galley] Fix an exception in clicking a thumbnail

This patch fixes the exception in clicking a thumbnail. It is a regression caused by r249027 and a possible cause of crbug.com/340624.

The 'length' property of the selection model is NOT the number of the selected item. To get it, we need to get the length of 'selectedIndex' property.

BUG=340624
TEST=manually

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251290

[yoshiki, 2014-02-12 16:54:17]

hirono, could you take a look? Thanks.

[hirono, 2014-02-13 04:57:07]

https://codereview.chromium.org/135973012/diff/1/chrome/browser/resources/fil...
File chrome/browser/resources/file_manager/foreground/js/photo/ribbon.js
(right):

https://codereview.chromium.org/135973012/diff/1/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/foreground/js/photo/ribbon.js:308:
this.selectionModel_.beginChange();
I'm not sure why the pair of methods fix the exception. Could you explain?

[yoshiki, 2014-02-13 06:32:45]

Sorry, I found the root cause and fixed it instead. The brief explanation is in
the description. PTAL again?

[hirono, 2014-02-13 06:42:22]

Thanks!

https://codereview.chromium.org/135973012/diff/90001/chrome/browser/resources...
File chrome/browser/resources/file_manager/foreground/js/photo/gallery.js
(right):

https://codereview.chromium.org/135973012/diff/90001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/photo/gallery.js:641: var
numSelectedItems = selectedIndex.length;
this.selectedIndexes.length?

[hirono, 2014-02-13 06:43:25]

https://codereview.chromium.org/135973012/diff/90001/chrome/browser/resources...
File chrome/browser/resources/file_manager/foreground/js/photo/gallery.js
(right):

https://codereview.chromium.org/135973012/diff/90001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/photo/gallery.js:641: var
numSelectedItems = selectedIndex.length;
On 2014/02/13 06:42:22, hirono wrote:
> this.selectedIndexes.length?

No, this.selectionModel_.selectedIndexes.length?

[yoshiki, 2014-02-13 07:59:08]

On 2014/02/13 06:43:25, hirono wrote:
>
https://codereview.chromium.org/135973012/diff/90001/chrome/browser/resources...
> File chrome/browser/resources/file_manager/foreground/js/photo/gallery.js
> (right):
> 
>
https://codereview.chromium.org/135973012/diff/90001/chrome/browser/resources...
> chrome/browser/resources/file_manager/foreground/js/photo/gallery.js:641: var
> numSelectedItems = selectedIndex.length;
> On 2014/02/13 06:42:22, hirono wrote:
> > this.selectedIndexes.length?
> 
> No, this.selectionModel_.selectedIndexes.length?

Thanks, I took a mistake at the last refactoring. PTAL again.

[hirono, 2014-02-13 08:06:56]

lgtm! Thanks!

[yoshiki, 2014-02-13 09:10:26]

The CQ bit was checked by yoshiki@chromium.org

[commit-bot: I haz the power, 2014-02-13 09:10:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/135973012/150001

[commit-bot: I haz the power, 2014-02-13 10:06:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-13 10:06:43]

Retried try job too often on win_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[yoshiki, 2014-02-14 04:47:39]

The CQ bit was checked by yoshiki@chromium.org

[commit-bot: I haz the power, 2014-02-14 04:49:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/135973012/150001

[commit-bot: I haz the power, 2014-02-14 13:43:30]

Change committed as 251290