Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 135973010: Revert of DevTools: Fix console.log for arrays in some corner cases. (Closed)

Created:
6 years, 10 months ago by pfeldman
Modified:
6 years, 10 months ago
Reviewers:
JulianMRaya, aandrey
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Revert of DevTools: Fix console.log for arrays in some corner cases. (https://codereview.chromium.org/143263003/) Reason for revert: Console output got messy. Original issue's description: > DevTools: Fix console.log for arrays in some corner cases. > > We didn't show array values defined on Array.prototype[], as well as non-index property names. > > BUG=320632, 163817 > R=pfeldman > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165713 TBR=JulianMRaya@gmail.com,aandrey@chromium.org NOTREECHECKS=true NOTRY=true BUG=320632, 163817 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166302

Patch Set 1 #

Patch Set 2 : Rebaselined #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -679 lines) Patch
M LayoutTests/http/tests/inspector/inspector-test.js View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/console/console-format.html View 1 2 chunks +3 lines, -9 lines 0 comments Download
D LayoutTests/inspector/console/console-format-array-prototype.html View 1 1 chunk +0 lines, -70 lines 0 comments Download
D LayoutTests/inspector/console/console-format-array-prototype-expected.txt View 1 1 chunk +0 lines, -62 lines 0 comments Download
M LayoutTests/inspector/console/console-format-expected.txt View 1 2 chunks +75 lines, -362 lines 0 comments Download
M LayoutTests/inspector/console/console-object-preview-accessors-expected.txt View 1 2 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/inspector/console/console-object-preview-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InjectedScriptSource.js View 1 4 chunks +8 lines, -23 lines 0 comments Download
M Source/devtools/front_end/ConsoleMessage.js View 1 4 chunks +57 lines, -134 lines 0 comments Download
M Source/devtools/front_end/utilities.js View 1 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
pfeldman
Created Revert of DevTools: Fix console.log for arrays in some corner cases.
6 years, 10 months ago (2014-02-01 10:08:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/135973010/1
6 years, 10 months ago (2014-02-01 10:09:07 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-01 10:09:10 UTC) #3
commit-bot: I haz the power
Failed to apply patch for LayoutTests/inspector/console/console-format-expected.txt: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 10 months ago (2014-02-01 10:09:11 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-01 10:09:13 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-01 10:09:15 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-01 10:09:20 UTC) #7
pfeldman
The CQ bit was checked by pfeldman@chromium.org
6 years, 10 months ago (2014-02-03 11:24:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/135973010/190001
6 years, 10 months ago (2014-02-03 11:24:56 UTC) #9
commit-bot: I haz the power
Change committed as 166302
6 years, 10 months ago (2014-02-03 11:25:18 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 11:25:21 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 11:25:22 UTC) #12
commit-bot: I haz the power
6 years, 10 months ago (2014-02-03 11:25:26 UTC) #13
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698