Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 135973009: Don't try to guess the referrer policy, but use the one associated with the request (Closed)

Created:
6 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jamesr
Visibility:
Public.

Description

Don't try to guess the referrer policy, but use the one associated with the request This is possible now that we store the referrer policy on each request. BUG=334125 R=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248650

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : updates #

Patch Set 4 : updates #

Patch Set 5 : new tests #

Patch Set 6 : updates #

Patch Set 7 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -88 lines) Patch
M chrome/browser/referrer_policy_browsertest.cc View 1 2 3 4 5 chunks +96 lines, -2 lines 0 comments Download
A chrome/test/data/referrer_policy/referrer-policy-iframe.html View 1 2 3 4 5 1 chunk +16 lines, -0 lines 0 comments Download
M chrome/test/data/referrer_policy/referrer-policy-start.html View 1 2 3 4 2 chunks +12 lines, -8 lines 0 comments Download
M content/child/npapi/plugin_url_fetcher.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/child/request_extra_data.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/child/request_extra_data.cc View 2 chunks +1 line, -4 lines 0 comments Download
M content/child/resource_dispatcher_unittest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/fetchers/resource_fetcher_impl.cc View 1 2 3 3 chunks +13 lines, -2 lines 0 comments Download
M content/renderer/internal_document_state_data.h View 3 chunks +0 lines, -19 lines 0 comments Download
M content/renderer/internal_document_state_data.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/renderer/pepper/url_request_info_util.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 7 chunks +15 lines, -14 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 4 5 6 5 chunks +4 lines, -15 lines 0 comments Download
M webkit/child/weburlloader_impl.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M webkit/child/weburlrequest_extradata_impl.h View 2 chunks +0 lines, -4 lines 0 comments Download
M webkit/child/weburlrequest_extradata_impl.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
jochen (gone - plz use gerrit)
6 years, 10 months ago (2014-01-31 22:34:22 UTC) #1
jochen (gone - plz use gerrit)
+nasko for content bits
6 years, 10 months ago (2014-01-31 23:27:28 UTC) #2
nasko
LGTM
6 years, 10 months ago (2014-01-31 23:44:49 UTC) #3
jochen (gone - plz use gerrit)
+mkwst for the chrome/ bits The History test will pass once blink rolls past r166272
6 years, 10 months ago (2014-02-02 22:33:41 UTC) #4
Mike West
chrome/* LGTM.
6 years, 10 months ago (2014-02-03 07:20:13 UTC) #5
jamesr
I'm really not a good reviewer for navigation patches. Adding creis@ as a potential content/ ...
6 years, 10 months ago (2014-02-03 21:49:40 UTC) #6
jochen (gone - plz use gerrit)
On 2014/02/03 21:49:40, jamesr wrote: > I'm really not a good reviewer for navigation patches. ...
6 years, 10 months ago (2014-02-03 22:10:47 UTC) #7
jamesr
I'm no better of a reviewer for navigation code in webkit/ than anywhere else, but ...
6 years, 10 months ago (2014-02-03 22:11:47 UTC) #8
Charlie Reis
Rubber stamp LGTM for content (partly deferring to Nasko's review).
6 years, 10 months ago (2014-02-03 22:44:09 UTC) #9
jochen (gone - plz use gerrit)
The CQ bit was checked by jochen@chromium.org
6 years, 10 months ago (2014-02-03 23:08:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/135973009/530001
6 years, 10 months ago (2014-02-03 23:11:18 UTC) #11
commit-bot: I haz the power
6 years, 10 months ago (2014-02-04 01:26:09 UTC) #12
Message was sent while issue was closed.
Change committed as 248650

Powered by Google App Engine
This is Rietveld 408576698