Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Issue 1359703002: Revert of Add debug symbols to all generated .isolate (bis). (Closed)

Created:
5 years, 3 months ago by paulmeyer
Modified:
5 years, 3 months ago
Reviewers:
jam, M-A Ruel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add debug symbols to all generated .isolate (bis). (patchset #2 id:20001 of https://codereview.chromium.org/1350413002/ ) Reason for revert: Broke many Mac tests, such as: https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/12106 Original issue's description: > Add debug symbols to all generated .isolate (bis). > > This will increase the amount of data being uploaded by a ~2x factor or so. > Debug symbols are usually larger than the executable itself on pretty much all > toolsets but generally have the advantage of being highly compressible. The > increase of data not a problem anymore with isolate-go. There will be a small > increase of latency but it should be bearable, especially by the gain of > enabling stack traces to work for isolated tests on Swarming. > > R=jam@chromium.org > BUG=98637 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/aad3ded46d115f94f1c501c5b21fa1ef73ef771b > Cr-Commit-Position: refs/heads/master@{#349953} TBR=jam@chromium.org,maruel@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=98637 Committed: https://crrev.com/f69e429c7c50d1243c72d78a17fb308e0d7a7668 Cr-Commit-Position: refs/heads/master@{#349983}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -101 lines) Patch
M tools/isolate_driver.py View 4 chunks +38 lines, -101 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
paulmeyer
Created Revert of Add debug symbols to all generated .isolate (bis).
5 years, 3 months ago (2015-09-21 18:56:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1359703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1359703002/1
5 years, 3 months ago (2015-09-21 18:56:56 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-21 18:58:50 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-21 18:59:58 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f69e429c7c50d1243c72d78a17fb308e0d7a7668
Cr-Commit-Position: refs/heads/master@{#349983}

Powered by Google App Engine
This is Rietveld 408576698