Android: improve native debuggability

base/debug/debugger_posix.cc

Index: base/debug/debugger_posix.cc
diff --git a/base/debug/debugger_posix.cc b/base/debug/debugger_posix.cc
index aef73ec7cbcd2839b892f44b2fed014bfcbd567e..e67ebe564e480b27450d3082744e6b8f9f9e4b9c 100644
--- a/base/debug/debugger_posix.cc
+++ b/base/debug/debugger_posix.cc
@@ -218,16 +218,21 @@ bool BeingDebugged() {
 // SIG triggered by native code.
 //
 // Use GDB to set |go| to 1 to resume execution.
-#define DEBUG_BREAK() do { \
-  if (!BeingDebugged()) { \
-    abort(); \
-  } else { \
-    volatile int go = 0; \
-    while (!go) { \
-      base::PlatformThread::Sleep(base::TimeDelta::FromMilliseconds(100)); \
-    } \
-  } \
-} while (0)
+namespace {
+  void DebugBreak() {
+    do {
+      if (!BeingDebugged()) {
+        abort();
+      } else {
+        volatile int go = 0;
+        while (!go) {
+          base::PlatformThread::Sleep(base::TimeDelta::FromMilliseconds(100));
+        }
+      }
+    } while (0);
+  }
+}

[bulach, 2013/04/08 14:13:58]

nit: 
}  // namespace

[Mostyn Bramley-Moore, 2013/04/08 14:17:35]

Done.

+#define DEBUG_BREAK() DebugBreak()
 #else
 // ARM && !ANDROID
 #define DEBUG_BREAK() asm("bkpt 0")