Chromium Code Reviews| Index: public/platform/modules/background_sync/WebSyncProvider.h |
| diff --git a/public/platform/modules/background_sync/WebSyncProvider.h b/public/platform/modules/background_sync/WebSyncProvider.h |
| index cb337a18b57f73680de012fefbe3aaf9af8b34be..9e71b847a26119e2c436380977d9d173ed917042 100644 |
| --- a/public/platform/modules/background_sync/WebSyncProvider.h |
| +++ b/public/platform/modules/background_sync/WebSyncProvider.h |
| @@ -48,25 +48,9 @@ public: |
| virtual void getPermissionStatus(blink::WebSyncRegistration::Periodicity, WebServiceWorkerRegistration*, WebSyncGetPermissionStatusCallbacks*) = 0; |
| // Takes ownership of the WebSyncNotifyWhenDoneCallbacks. |
| - virtual void notifyWhenDone(int64_t syncId, WebSyncNotifyWhenDoneCallbacks* callbacks) |
| - { |
| - // TODO(jkarlin): After landing both legs of the notifyWhenDone CLs, make this a pure virtual function. |
| - callbacks->onError(WebSyncError(WebSyncError::ErrorTypeAbort, "Function not implemented.")); |
| - delete callbacks; |
| - } |
| + virtual void notifyWhenDone(int64_t syncId, WebSyncNotifyWhenDoneCallbacks*); |
|
jsbell
2015/09/21 17:28:28
Uh, don't you want `= 0` here?
jkarlin
2015/09/21 17:32:38
Sorry, I meant to fix that before you saw it! Done
|
| - // Takes ownership of the WebServiceWorkerRegistration. |
| - virtual void trackRegistration(WebSyncRegistration* registration) |
| - { |
| - // TODO(jkarlin): After landing both legs of the releaseRegistration CLs, make this a pure virtual function. |
| - return; |
| - } |
| - |
| - virtual void releaseRegistration(int64_t syncId) |
| - { |
| - // TODO(jkarlin): After landing both legs of the releaseRegistration CLs, make this a pure virtual function. |
| - return; |
| - } |
| + virtual void releaseRegistration(int64_t syncId); |
|
jsbell
2015/09/21 17:28:28
Ditto?
jkarlin
2015/09/21 17:32:38
Done.
|
| }; |
| } // namespace blink |