PDF: Prevent left/right arrow shortcuts when a PDF text field is focused.

chrome/browser/resources/pdf/pdf.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * @return {number} Width of a scrollbar in pixels
  */
 function getScrollbarWidth() {
@@ skipping 97 matching lines @@
  * Creates a new PDFViewer. There should only be one of these objects per
  * document.
  * @constructor
  * @param {!BrowserApi} browserApi An object providing an API to the browser.
  */
 function PDFViewer(browserApi) {
   this.browserApi_ = browserApi;
   this.loadState_ = LoadState.LOADING;
   this.parentWindow_ = null;
   this.parentOrigin_ = null;
+  this.pluginFormFieldFocus_ = false;

[raymes, 2015/09/22 04:35:25]

nit: maybe just:
isFormFieldFocused_

[tsergeant, 2015/09/22 04:55:28]

Done.

 
   this.delayedScriptingMessages_ = [];
 
   this.isPrintPreview_ = this.browserApi_.getStreamInfo().originalUrl.indexOf(
                              'chrome://print') == 0;
   this.isMaterial_ = location.pathname.substring(1) === 'index-material.html';
 
   // The sizer element is placed behind the plugin element to cause scrollbars
   // to be displayed in the window. It is sized according to the document size
   // of the pdf and zoom level.
@@ skipping 190 matching lines @@
           pageDownHandler();
         return;
       case 33:  // Page up key.
         pageUpHandler();
         return;
       case 34:  // Page down key.
         pageDownHandler();
         return;
       case 37:  // Left arrow key.
         if (!(e.altKey || e.ctrlKey || e.metaKey || e.shiftKey)) {
-          // Go to the previous page if there are no horizontal scrollbars.
-          if (!this.viewport_.documentHasScrollbars().horizontal) {
+          // Go to the previous page if there are no horizontal scrollbars and
+          // no form field is focused.
+          if (!(this.viewport_.documentHasScrollbars().horizontal ||
+                this.pluginFormFieldFocus_)) {
             this.viewport_.goToPage(this.viewport_.getMostVisiblePage() - 1);
             // Since we do the movement of the page.
             e.preventDefault();
           } else if (fromScriptingAPI) {
             position.x -= Viewport.SCROLL_INCREMENT;
             this.viewport.position = position;
           }
         }
         return;
       case 38:  // Up arrow key.
         if (fromScriptingAPI) {
           position.y -= Viewport.SCROLL_INCREMENT;
           this.viewport.position = position;
         }
         return;
       case 39:  // Right arrow key.
         if (!(e.altKey || e.ctrlKey || e.metaKey || e.shiftKey)) {
-          // Go to the next page if there are no horizontal scrollbars.
-          if (!this.viewport_.documentHasScrollbars().horizontal) {
+          // Go to the next page if there are no horizontal scrollbars and no
+          // form field is focused.
+          if (!(this.viewport_.documentHasScrollbars().horizontal ||
+                this.pluginFormFieldFocus_)) {
             this.viewport_.goToPage(this.viewport_.getMostVisiblePage() + 1);
             // Since we do the movement of the page.
             e.preventDefault();
           } else if (fromScriptingAPI) {
             position.x += Viewport.SCROLL_INCREMENT;
             this.viewport.position = position;
           }
         }
         return;
       case 40:  // Down arrow key.
@@ skipping 301 matching lines @@
           this.materialToolbar_.bookmarks = this.bookmarks;
         }
         break;
       case 'setIsSelecting':
         this.viewportScroller_.setEnableScrolling(message.data.isSelecting);
         break;
       case 'getNamedDestinationReply':
         this.paramsParser_.onNamedDestinationReceived(
             message.data.pageNumber);
         break;
+      case 'formFocusChange':
+        this.pluginFormFieldFocus_ = message.data.focused;
+        break;
     }
   },
 
   /**
    * @private
    * A callback that's called before the zoom changes. Notify the plugin to stop
    * reacting to scroll events while zoom is taking place to avoid flickering.
    */
   beforeZoom_: function() {
     this.plugin_.postMessage({
@@ skipping 223 matching lines @@
    * Each bookmark is an Object containing a:
    * - title
    * - page (optional)
    * - array of children (themselves bookmarks)
    * @type {Array} the top-level bookmarks of the PDF.
    */
   get bookmarks() {
     return this.bookmarks_;
   }
 };