Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1359613002: PDF: Prevent left/right arrow shortcuts when a PDF text field is focused. (Closed)

Created:
5 years, 3 months ago by tsergeant
Modified:
5 years, 3 months ago
Reviewers:
raymes
CC:
arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PDF: Prevent left/right arrow shortcuts when a PDF text field is focused. This fixes an issue where pressing left or right while editing a form would change page as well as move the caret. BUG=490004 Committed: https://crrev.com/bf5a8f6f14f9efe010a1fb7380440ed776984cc9 Cr-Commit-Position: refs/heads/master@{#350322}

Patch Set 1 #

Patch Set 2 : Add test #

Patch Set 3 : Fix comment #

Total comments: 2

Patch Set 4 : Rename variable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -4 lines) Patch
M chrome/browser/pdf/pdf_extension_test.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/resources/pdf/pdf.js View 1 2 3 4 chunks +12 lines, -4 lines 0 comments Download
A chrome/test/data/pdf/page_change_test.js View 1 2 3 1 chunk +74 lines, -0 lines 0 comments Download
M pdf/out_of_process_instance.cc View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
tsergeant
5 years, 3 months ago (2015-09-22 03:46:23 UTC) #2
raymes
lgtm! https://codereview.chromium.org/1359613002/diff/40001/chrome/browser/resources/pdf/pdf.js File chrome/browser/resources/pdf/pdf.js (right): https://codereview.chromium.org/1359613002/diff/40001/chrome/browser/resources/pdf/pdf.js#newcode118 chrome/browser/resources/pdf/pdf.js:118: this.pluginFormFieldFocus_ = false; nit: maybe just: isFormFieldFocused_
5 years, 3 months ago (2015-09-22 04:35:25 UTC) #3
tsergeant
https://codereview.chromium.org/1359613002/diff/40001/chrome/browser/resources/pdf/pdf.js File chrome/browser/resources/pdf/pdf.js (right): https://codereview.chromium.org/1359613002/diff/40001/chrome/browser/resources/pdf/pdf.js#newcode118 chrome/browser/resources/pdf/pdf.js:118: this.pluginFormFieldFocus_ = false; On 2015/09/22 at 04:35:25, raymes wrote: ...
5 years, 3 months ago (2015-09-22 04:55:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1359613002/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1359613002/50001
5 years, 3 months ago (2015-09-22 04:55:36 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/71912)
5 years, 3 months ago (2015-09-22 07:56:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1359613002/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1359613002/50001
5 years, 3 months ago (2015-09-22 22:58:29 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/72318)
5 years, 3 months ago (2015-09-23 04:46:56 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1359613002/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1359613002/50001
5 years, 3 months ago (2015-09-23 05:43:57 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:50001)
5 years, 3 months ago (2015-09-23 06:54:43 UTC) #16
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 06:55:29 UTC) #17
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/bf5a8f6f14f9efe010a1fb7380440ed776984cc9
Cr-Commit-Position: refs/heads/master@{#350322}

Powered by Google App Engine
This is Rietveld 408576698