Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1359583002: [builtins] Add support for NewTarget to Execution::New. (Closed)

Created:
5 years, 3 months ago by Benedikt Meurer
Modified:
5 years, 3 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Add support for NewTarget to Execution::New. Introduce new builtins Construct and ConstructFunction (in line with the Call and CallFunction builtins that we already have) as proper bottleneck for Construct and [[Construct]] on JSFunctions. Use these builtins to support passing NewTarget from C++ to JavaScript land. Long-term we want the CallConstructStub to be used for gathering feedback on entry to construction chain (i.e. the initial new Foo), and use the Construct builtins to do the actual work inside the construction chain (i.e. calling into super and stuff). MIPS and MIPS64 ports contributed by akos.palfi@imgtec.com. R=jarin@chromium.org BUG=v8:4430 LOG=n Committed: https://crrev.com/1dfac69f1fb5ad8e2db2d5be591c094def55d451 Cr-Commit-Position: refs/heads/master@{#30857}

Patch Set 1 #

Patch Set 2 : REBASE. Merge mips and mips64 ports. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+706 lines, -427 lines) Patch
M src/arm/builtins-arm.cc View 7 chunks +88 lines, -16 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 2 chunks +11 lines, -36 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 8 chunks +88 lines, -15 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 2 chunks +12 lines, -39 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 chunk +12 lines, -5 lines 0 comments Download
M src/arm64/simulator-arm64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/simulator-arm64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/builtins.h View 2 chunks +8 lines, -0 lines 0 comments Download
M src/execution.h View 1 chunk +6 lines, -7 lines 0 comments Download
M src/execution.cc View 4 chunks +17 lines, -11 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 3 chunks +7 lines, -10 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 3 chunks +7 lines, -10 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 3 chunks +7 lines, -10 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 2 chunks +3 lines, -8 lines 0 comments Download
M src/globals.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 5 chunks +87 lines, -18 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 chunks +14 lines, -41 lines 0 comments Download
M src/ia32/frames-ia32.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/builtins-mips.cc View 1 7 chunks +86 lines, -14 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 2 chunks +11 lines, -35 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 1 7 chunks +85 lines, -14 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 2 chunks +12 lines, -35 lines 0 comments Download
M src/runtime/runtime-classes.cc View 1 chunk +3 lines, -15 lines 0 comments Download
M src/x64/builtins-x64.cc View 12 chunks +111 lines, -29 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 chunks +14 lines, -40 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Benedikt Meurer
Hey MIPS people, Please port this to mips and mips64. Thanks, Benedikt
5 years, 3 months ago (2015-09-21 07:36:26 UTC) #4
Benedikt Meurer
Hey Jaro, This is next step in Execution::New/Call refactoring, only one step away from having ...
5 years, 3 months ago (2015-09-21 07:58:55 UTC) #7
Jarin
lgtm
5 years, 3 months ago (2015-09-21 21:44:12 UTC) #8
paul.l...
Hi Benedikt, please find MIPS ports from Ákos in https://codereview.chromium.org/1346963005/
5 years, 3 months ago (2015-09-22 03:54:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1359583002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1359583002/100001
5 years, 3 months ago (2015-09-22 04:01:37 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:100001)
5 years, 3 months ago (2015-09-22 04:27:19 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 04:27:34 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1dfac69f1fb5ad8e2db2d5be591c094def55d451
Cr-Commit-Position: refs/heads/master@{#30857}

Powered by Google App Engine
This is Rietveld 408576698