Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1359563002: Performance tests should use GCController.collectAll instead of GCController.collect (Closed)

Created:
5 years, 3 months ago by haraken
Modified:
5 years, 3 months ago
Reviewers:
oilpan-reviews, keishi
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Performance tests should use GCController.collectAll instead of GCController.collect To make sure that (almost) all garbage is collected, it's better to use GCController.collectAll. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202660

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M PerformanceTests/resources/runner.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
haraken
PTAL
5 years, 3 months ago (2015-09-19 05:39:22 UTC) #2
keishi
lgtm LGTM
5 years, 3 months ago (2015-09-19 05:42:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1359563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1359563002/1
5 years, 3 months ago (2015-09-19 05:42:42 UTC) #5
commit-bot: I haz the power
Exceeded global retry quota
5 years, 3 months ago (2015-09-19 05:45:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1359563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1359563002/1
5 years, 3 months ago (2015-09-19 05:59:48 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/115937)
5 years, 3 months ago (2015-09-19 06:02:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1359563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1359563002/1
5 years, 3 months ago (2015-09-23 03:21:43 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 04:09:05 UTC) #14
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202660

Powered by Google App Engine
This is Rietveld 408576698