Issue 135953002: PNaCl: Fix handling of va_arg on structs in simplification passes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 135953002: PNaCl: Fix handling of va_arg on structs in simplification passes (Closed)

Created:
6 years, 11 months ago by Mark Seaborn

Modified:
6 years, 11 months ago

Reviewers:
Derek Schuff

CC:
native-client-reviews_googlegroups.com

Base URL:
http://git.chromium.org/native_client/pnacl-llvm.git@master

Visibility:
Public.

PNaCl: Fix handling of va_arg on structs in simplification passes Without this ordering change, ExpandStructRegs will fail with: Value: %val = va_arg i8* %va_list, %MyStruct LLVM ERROR: Unrecognized struct value BUG=https://code.google.com/p/nativeclient/issues/detail?id=2381 TEST=*.ll tests R=dschuff@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-llvm.git;a=commit;h=91eed9e

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -16 lines)			Patch
M	lib/Transforms/NaCl/ExpandVarArgs.cpp	View	1	1 chunk	+8 lines, -14 lines	0 comments	Download
M	lib/Transforms/NaCl/PNaClABISimplify.cpp	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	test/Transforms/NaCl/pnacl-abi-simplify-preopt.ll	View		1 chunk	+12 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Mark Seaborn

6 years, 11 months ago (2014-01-13 17:30:22 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r91eed9e (presubmit successful).