Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 1359513002: Various fixes for 32-bit Linux GN builds that need to be tracked down. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: share snapshot_toolchain.gni Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/installer/BUILD.gn » ('j') | chrome/test/base/js2gtest.gni » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/toolchain/ccache.gni") 8 import("//build/toolchain/ccache.gni")
9 9
10 if (current_cpu == "arm") { 10 if (current_cpu == "arm") {
(...skipping 26 matching lines...) Expand all
37 # example, don't omit the frame pointer and leave in symbols. 37 # example, don't omit the frame pointer and leave in symbols.
38 enable_profiling = false 38 enable_profiling = false
39 39
40 # Compile in such a way as to make it possible for the profiler to unwind full 40 # Compile in such a way as to make it possible for the profiler to unwind full
41 # stack frames. Setting this flag has a large effect on the performance of the 41 # stack frames. Setting this flag has a large effect on the performance of the
42 # generated code than just setting profiling, but gives the profiler more 42 # generated code than just setting profiling, but gives the profiler more
43 # information to analyze. 43 # information to analyze.
44 # Requires profiling to be set to true. 44 # Requires profiling to be set to true.
45 enable_full_stack_frames_for_profiling = false 45 enable_full_stack_frames_for_profiling = false
46 46
47 # Use 64-bit gold for linking on both 64-bit Linux and 32-bit linux; 47 # TODO(GYP): We should be using 64-bit gold for linking on both 64-bit Linux
48 # 32-bit Gold runs out of address-space on 32-bit bit builds. 48 # and 32-bit linux; 32-bit Gold runs out of address-space on 32-bit builds.
49 use_gold = is_linux && (current_cpu == "x64" || current_cpu == "x86") 49 # However, something isn't quite working right on the 32-bit builds.
50 use_gold = is_linux && current_cpu == "x64"
Roland McGrath 2015/09/21 23:59:07 I investigated the gold crash a bit. It still hap
50 51
51 # When we are going to use gold we need to find it. 52 # When we are going to use gold we need to find it.
52 if (use_gold) { 53 if (use_gold) {
53 gold_path = rebase_path("//third_party/binutils/Linux_x64/Release/bin", 54 gold_path = rebase_path("//third_party/binutils/Linux_x64/Release/bin",
54 root_build_dir) 55 root_build_dir)
55 } else { 56 } else {
56 gold_path = "" 57 gold_path = ""
57 } 58 }
58 59
59 # use_debug_fission: whether to use split DWARF debug info 60 # use_debug_fission: whether to use split DWARF debug info
(...skipping 1427 matching lines...) Expand 10 before | Expand all | Expand 10 after
1487 } else if (symbol_level == 1) { 1488 } else if (symbol_level == 1) {
1488 cflags = minimal_symbols_cflags 1489 cflags = minimal_symbols_cflags
1489 ldflags = minimal_symbols_ldflags 1490 ldflags = minimal_symbols_ldflags
1490 } else if (symbol_level == 2) { 1491 } else if (symbol_level == 2) {
1491 cflags = symbols_cflags 1492 cflags = symbols_cflags
1492 ldflags = symbols_ldflags 1493 ldflags = symbols_ldflags
1493 } else { 1494 } else {
1494 assert(false) 1495 assert(false)
1495 } 1496 }
1496 } 1497 }
OLDNEW
« no previous file with comments | « no previous file | chrome/installer/BUILD.gn » ('j') | chrome/test/base/js2gtest.gni » ('J')

Powered by Google App Engine
This is Rietveld 408576698