Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1359493002: [MD settings] moving attached() code (Closed)

Created:
5 years, 3 months ago by dschuyler
Modified:
5 years, 3 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, jhawkins+watch-md-settings_chromium.org, arv+watch_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] moving attached() code This CL moves some code to better match the style directed in https://docs.google.com/document/d/1G0t519y_cSW4etXVwruR145abZH0N5-9R7JyejzVoTs/edit#heading=h.q9zwsnbflnjp BUG=531786 Committed: https://crrev.com/3a0e40d7099b105e6c45b6cb89af3c47b1e5026d Cr-Commit-Position: refs/heads/master@{#349799}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -13 lines) Patch
M chrome/browser/resources/settings/appearance_page/appearance_page.js View 3 chunks +11 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dschuyler
5 years, 3 months ago (2015-09-18 22:13:49 UTC) #2
stevenjb
lgtm
5 years, 3 months ago (2015-09-18 22:32:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1359493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1359493002/1
5 years, 3 months ago (2015-09-18 22:36:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-18 23:03:22 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 23:04:00 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3a0e40d7099b105e6c45b6cb89af3c47b1e5026d
Cr-Commit-Position: refs/heads/master@{#349799}

Powered by Google App Engine
This is Rietveld 408576698