remoting/protocol/jingle_session.cc - Issue 1359453003: Use the appropriate variant of IntToString in //remoting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/protocol/jingle_session.cc

Issue 1359453003: Use the appropriate variant of IntToString in //remoting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: remoting/protocol/jingle_session.cc

diff --git a/remoting/protocol/jingle_session.cc b/remoting/protocol/jingle_session.cc

index 1dacef1f45a0096db699fe84e366eb19a1f6e102..b5fdadd41aa2d5c5734b674c9e978d32b8a4d72e 100644

--- a/remoting/protocol/jingle_session.cc

+++ b/remoting/protocol/jingle_session.cc

@@ -114,7 +114,7 @@ void JingleSession::StartConnection(const std::string& peer_jid,

// concurrent session per host, so a random 64-bit integer provides

// enough entropy. In the worst case connection will fail when two

// clients generate the same session ID concurrently.

- session_id_ = base::Int64ToString(base::RandGenerator(kint64max));

+ session_id_ = base::Uint64ToString(base::RandGenerator(kint64max));

Sergey Ulanov 2015/09/19 00:48:10 please change kint64max -> kuint64max

Adam Rice 2015/09/19 03:38:41 Done.

quic_channel_factory_.reset(new QuicChannelFactory(session_id_, false));

« no previous file with comments | « remoting/protocol/jingle_messages.cc ('k') | remoting/protocol/message_decoder_unittest.cc » ('j') | no next file with comments »