Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1359453003: Use the appropriate variant of IntToString in //remoting (Closed)

Created:
5 years, 3 months ago by Adam Rice
Modified:
5 years, 3 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the appropriate variant of IntToString in //remoting Using the wrong variant of IntToString() can lead to unexpected behaviour and bugs. Use the appropriate variant for the type being converted. No behaviour change intended. BUG=505479 TEST=compiled Committed: https://crrev.com/ac43082b768f2e9be967f8c0132d9c6fc7d0fb01 Cr-Commit-Position: refs/heads/master@{#349876}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use the full range of uint64 in RandGenerator. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M remoting/protocol/jingle_messages.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/protocol/jingle_session.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/message_decoder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Adam Rice
5 years, 3 months ago (2015-09-18 22:55:08 UTC) #2
Sergey Ulanov
LGTM. Thank you for the fix! https://codereview.chromium.org/1359453003/diff/1/remoting/protocol/jingle_session.cc File remoting/protocol/jingle_session.cc (right): https://codereview.chromium.org/1359453003/diff/1/remoting/protocol/jingle_session.cc#newcode117 remoting/protocol/jingle_session.cc:117: session_id_ = base::Uint64ToString(base::RandGenerator(kint64max)); ...
5 years, 3 months ago (2015-09-19 00:48:10 UTC) #3
Adam Rice
https://codereview.chromium.org/1359453003/diff/1/remoting/protocol/jingle_session.cc File remoting/protocol/jingle_session.cc (right): https://codereview.chromium.org/1359453003/diff/1/remoting/protocol/jingle_session.cc#newcode117 remoting/protocol/jingle_session.cc:117: session_id_ = base::Uint64ToString(base::RandGenerator(kint64max)); On 2015/09/19 at 00:48:10, Sergey Ulanov ...
5 years, 3 months ago (2015-09-19 03:38:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1359453003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1359453003/20001
5 years, 3 months ago (2015-09-20 05:17:49 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-20 06:25:52 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-20 06:26:37 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ac43082b768f2e9be967f8c0132d9c6fc7d0fb01
Cr-Commit-Position: refs/heads/master@{#349876}

Powered by Google App Engine
This is Rietveld 408576698