Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: src/gpu/batches/GrRectBatchFactory.cpp

Issue 1359453002: Fix for degenerate stroke rect (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: feedback inc Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/batches/GrRectBatchFactory.cpp
diff --git a/src/gpu/batches/GrRectBatchFactory.cpp b/src/gpu/batches/GrRectBatchFactory.cpp
index eed18ad419637e788065495cf2729ae748fb6fa1..ca8bc1f84a63d594d4f17edc4e31cf59c37fdb4f 100644
--- a/src/gpu/batches/GrRectBatchFactory.cpp
+++ b/src/gpu/batches/GrRectBatchFactory.cpp
@@ -33,13 +33,6 @@ GrDrawBatch* CreateAAStroke(GrColor color,
const SkScalar rx = SkScalarMul(dx, SK_ScalarHalf);
const SkScalar ry = SkScalarMul(dy, SK_ScalarHalf);
- SkScalar spare;
- {
- SkScalar w = devRect.width() - dx;
- SkScalar h = devRect.height() - dy;
- spare = SkTMin(w, h);
- }
-
SkRect devOutside(devRect);
devOutside.outset(rx, ry);
@@ -51,12 +44,10 @@ GrDrawBatch* CreateAAStroke(GrColor color,
miterStroke = false;
}
- if (spare <= 0 && miterStroke) {
- return CreateAAFill(color, viewMatrix, devOutside, devOutside);
- }
-
SkRect devInside(devRect);
robertphillips 2015/09/20 15:49:40 It seems like we could get cracking with this meth
- devInside.inset(rx, ry);
+ SkScalar insideRx = SkTMin(devRect.width() / 2.0f, rx);
+ SkScalar insideRy = SkTMin(devRect.height() / 2.0f, ry);
+ devInside.inset(insideRx, insideRy);
SkRect devOutsideAssist(devRect);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698