Issue 1359443005: move constants into common

Issue 1359443005: move constants into common (Closed)

Created:
5 years, 3 months ago by fbarchard1

Modified:
5 years, 3 months ago

Reviewers:
harryjin, fbarchard

Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master

Target Ref:
refs/heads/master

Project:
libyuv

Visibility:
Public.

Description

move constants into common R=harryjin@google.com BUG=libyuv:488 Committed: https://chromium.googlesource.com/libyuv/libyuv/+/62c49dc811f078e78ed76bfd7c6358c8b7513a14

Patch Set 2 : move neon structs to common #

Patch Set 4 : fix up jpeg comments and remove todo to move to common #

Created: 5 years, 3 months ago

	Unified diffs	Side-by-side diffs	Stats (+116 lines, -503 lines)
M	README.chromium	View	1 chunk	+1 line, -1 line	0 comments
M	include/libyuv/row.h	View	2 chunks	+17 lines, -0 lines	0 comments
M	include/libyuv/version.h	View	1 chunk	+1 line, -1 line	0 comments
M	source/row_common.cc	View	8 chunks	+97 lines, -17 lines	0 comments
M	source/row_gcc.cc	View	1 chunk	+0 lines, -161 lines	0 comments
M	source/row_neon.cc	View	1 chunk	+0 lines, -116 lines	0 comments
M	source/row_neon64.cc	View	1 chunk	+0 lines, -38 lines	0 comments
M	source/row_win.cc	View	1 chunk	+0 lines, -169 lines	0 comments

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

harryjin

https://codereview.chromium.org/1359443005/diff/1/source/row_common.cc File source/row_common.cc (left): https://codereview.chromium.org/1359443005/diff/1/source/row_common.cc#oldcode1034 source/row_common.cc:1034: Why removing this empty line? https://codereview.chromium.org/1359443005/diff/1/source/row_common.cc File source/row_common.cc (right): ...

5 years, 3 months ago (2015-09-18 22:48:31 UTC) #2

fbarchard

https://codereview.chromium.org/1359443005/diff/1/source/row_common.cc File source/row_common.cc (left): https://codereview.chromium.org/1359443005/diff/1/source/row_common.cc#oldcode1034 source/row_common.cc:1034: On 2015/09/18 22:48:31, harryjin wrote: > Why removing this ...

5 years, 3 months ago (2015-09-18 22:51:12 UTC) #4

fbarchard1

5 years, 3 months ago (2015-09-18 23:28:48 UTC) #6

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as
62c49dc811f078e78ed76bfd7c6358c8b7513a14 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages