Issue 135943003: Roll Skia DEPS to r13035

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 135943003: Roll Skia DEPS to r13035 (Closed)

Created:
6 years, 11 months ago by robertphillips

Modified:
6 years, 11 months ago

Reviewers:
bsalomon, rmistry, reed1

CC:
chromium-reviews, skia-team_google.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Roll Skia DEPS to r13035 R=rmistry@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244495

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	DEPS	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

robertphillips

control: https://codereview.chromium.org/133773004/

6 years, 11 months ago (2014-01-12 15:00:28 UTC) #1

robertphillips

I believe this is 'good'. The discrepancies between the roll and control are: android_dbg roll: ...

6 years, 11 months ago (2014-01-13 13:02:25 UTC) #2

I believe this is 'good'. The discrepancies between the roll and control are:

android_dbg
   roll:    
            slave_steps 
            androidwebview_instrumentation_tests 
   control: 
            slave_steps
            compile 

mac_asan
   roll:    
            buildrunner_tests 
            telemetry_unittests failed 3
                testMultipleTabCalls
                testRuntimeEvaluateSimple ************************************
                testBasicHostingAndRangeRequests
            browser_tests 341 disabled 36 flaky failed 4
                MediaAccessAPIDeny_TestDenyThenAllowThrows *******************
                MediaAccessAPIDeny_TestDenyWithPreventDefault ****************
                MediaAccessAPIDeny_TestNoListenersImplyDeny ******************
                MediaAccessAPIDeny_TestNoPreventDefaultImpliesDeny ***********
            content_browsertests 33 disabled failed 56
                ... **********************************************************
   control: 
            buildrunner_tests 
            telemetry_unittests failed 3
                testMultipleTabCalls
                testPlayWaitForEnded
                testBasicHostingAndRangeRequests

win
   roll:    
            buildrunner_tests
            telemetry_unittests failed 2
                testMultipleTabCalls *****************************************
                testBasicHostingAndRangeRequests *****************************
            content_browsertests 56 disabled 7 flaky failed 1
                LimitTotal ***************************************************
   control: 
            green

win_layout
   roll:    
            webkit_tests 271 fixable (0 skipped) failed 2
                appcache-swap.html *******************************************
                online-whitelist.html ****************************************
   control: 
            webkit_tests 294 fixable (0 skipped) crashed or hung unexpected
flaky 33
                ...

robertphillips

6 years, 11 months ago (2014-01-13 13:08:16 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r244495 (presubmit successful).

Expand Messages | Collapse Messages