Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 13594009: Correct scale for touch radius & scroll offset ordinal (Closed)

Created:
7 years, 8 months ago by Yufeng Shen (Slow to review)
Modified:
7 years, 8 months ago
Reviewers:
sadrul, oshima, sky
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Correct scale for touch radius & scroll offset ordinal In https://codereview.chromium.org/12983010/ reversed_root_transform is passed into event::UpdateForRootTransform. Then for TouchEvent::UpdateForRootTransform(), the radius_x/y now should times the inverted device scale factor instead of being divided by it. The same in ScrollEvent::UpdateForRootTransform() for scroll offset ordinal. BUG=chromium:226169 TEST=On Link, visit http://www.rbyers.net/paint.html, make sure touch radius has normal range. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192490

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixed also ScrollEvent::UpdateForRootTransform #

Patch Set 3 : fixed nit #

Patch Set 4 : added tests #

Patch Set 5 : tests added #

Total comments: 2

Patch Set 6 : add const for "DesktopBackgroundView" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -16 lines) Patch
M ash/display/display_controller_unittest.cc View 1 2 3 4 5 4 chunks +90 lines, -2 lines 0 comments Download
M ui/aura/test/event_generator.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/events/event.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/events/event.cc View 1 2 2 chunks +12 lines, -10 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Yufeng Shen (Slow to review)
7 years, 8 months ago (2013-04-03 23:05:10 UTC) #1
sadrul
https://codereview.chromium.org/13594009/diff/1/ui/base/events/event.cc File ui/base/events/event.cc (right): https://codereview.chromium.org/13594009/diff/1/ui/base/events/event.cc#newcode700 ui/base/events/event.cc:700: x_offset_ordinal_ /= decomp.scale[0]; Please fix these too?
7 years, 8 months ago (2013-04-03 23:09:04 UTC) #2
Yufeng Shen (Slow to review)
https://codereview.chromium.org/13594009/diff/1/ui/base/events/event.cc File ui/base/events/event.cc (right): https://codereview.chromium.org/13594009/diff/1/ui/base/events/event.cc#newcode700 ui/base/events/event.cc:700: x_offset_ordinal_ /= decomp.scale[0]; On 2013/04/03 23:09:04, sadrul wrote: > ...
7 years, 8 months ago (2013-04-03 23:19:15 UTC) #3
sadrul
Awesome. Thanks! Mind updating the CL description too? LGTM (FWIW)
7 years, 8 months ago (2013-04-03 23:25:32 UTC) #4
oshima
lgtm Sorry for not updating them, and thank you for fixing!
7 years, 8 months ago (2013-04-03 23:27:26 UTC) #5
oshima
On 2013/04/03 23:27:26, oshima wrote: > lgtm > > Sorry for not updating them, and ...
7 years, 8 months ago (2013-04-03 23:29:25 UTC) #6
Yufeng Shen (Slow to review)
tests added. PTAL
7 years, 8 months ago (2013-04-04 17:17:53 UTC) #7
sadrul
Please make sure to update the CL description before landing.
7 years, 8 months ago (2013-04-04 17:21:06 UTC) #8
Yufeng Shen (Slow to review)
CL title and message updated.
7 years, 8 months ago (2013-04-04 17:46:14 UTC) #9
oshima
lgtm with nit https://codereview.chromium.org/13594009/diff/15002/ash/display/display_controller_unittest.cc File ash/display/display_controller_unittest.cc (right): https://codereview.chromium.org/13594009/diff/15002/ash/display/display_controller_unittest.cc#newcode125 ash/display/display_controller_unittest.cc:125: if (target->name() != "DesktopBackgroundView") since this ...
7 years, 8 months ago (2013-04-04 17:57:08 UTC) #10
Yufeng Shen (Slow to review)
add sky@ for OWNERS https://codereview.chromium.org/13594009/diff/15002/ash/display/display_controller_unittest.cc File ash/display/display_controller_unittest.cc (right): https://codereview.chromium.org/13594009/diff/15002/ash/display/display_controller_unittest.cc#newcode125 ash/display/display_controller_unittest.cc:125: if (target->name() != "DesktopBackgroundView") On ...
7 years, 8 months ago (2013-04-04 18:13:12 UTC) #11
sky
LGTM
7 years, 8 months ago (2013-04-04 20:21:31 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miletus@chromium.org/13594009/21001
7 years, 8 months ago (2013-04-04 20:52:54 UTC) #13
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=6711
7 years, 8 months ago (2013-04-04 21:21:19 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miletus@chromium.org/13594009/21001
7 years, 8 months ago (2013-04-04 22:44:57 UTC) #15
commit-bot: I haz the power
7 years, 8 months ago (2013-04-05 04:02:38 UTC) #16
Message was sent while issue was closed.
Change committed as 192490

Powered by Google App Engine
This is Rietveld 408576698