Issue 1359393004: Revert of remove unused SkCachingPixelRef

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1359393004: Revert of remove unused SkCachingPixelRef (Closed)

Created:
5 years, 3 months ago by dogben

Modified:
5 years, 3 months ago

Reviewers:
hal.canary, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of remove unused SkCachingPixelRef (patchset #1 id:1 of https://codereview.chromium.org/1364743002/ ) Reason for revert: Build failure: https://uberchromegw.corp.google.com/i/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android_FrameworkDefs/builds/1146 Original issue's description: > remove unused SkCachingPixelRef > > BUG=skia: > TBR= > > Committed: https://skia.googlesource.com/skia/+/70d58b7da535e32bcac35739d11ab8367e99f224 TBR=halcanary@google.com,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/60c73d51808b9d78f65381b83f628a3f523042fe

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+184 lines, -9 lines)			Patch
M	gyp/core.gypi	View	1 chunk	+4 lines, -0 lines	0 comments	Download
A	src/lazy/SkCachingPixelRef.h	View	1 chunk	+67 lines, -0 lines	0 comments	Download
A	src/lazy/SkCachingPixelRef.cpp	View	1 chunk	+74 lines, -0 lines	0 comments	Download
M	tests/CachedDecodingPixelRefTest.cpp	View	5 chunks	+39 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1359393004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1359393004/1

5 years, 3 months ago (2015-09-23 18:53:31 UTC) #2

commit-bot: I haz the power

5 years, 3 months ago (2015-09-23 18:53:43 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/60c73d51808b9d78f65381b83f628a3f523042fe

Expand Messages | Collapse Messages