webapps: Add cleanup task when opening up WebappActivity to clean old web apps

chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappRegistryTest.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.webapps;
 
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertTrue;
 
 import android.content.Context;
 import android.content.SharedPreferences;
+import android.os.SystemClock;
 
 import org.chromium.base.test.util.Feature;
 import org.chromium.testing.local.BackgroundShadowAsyncTask;
 import org.chromium.testing.local.LocalRobolectricTestRunner;
 import org.junit.Before;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.robolectric.Robolectric;
 import org.robolectric.annotation.Config;
 
@@ skipping 155 matching lines @@
                 .putLong(WebappDataStorage.KEY_LAST_USED, 100L)
                 .commit();
 
         WebappRegistry.unregisterAllWebapps(Robolectric.application, null);
         BackgroundShadowAsyncTask.runBackgroundTasks();
 
         Map<String, ?> actual = webAppPrefs.getAll();
         assertTrue(actual.isEmpty());
     }
 
+    @Test
+    @Feature({"Webapp"})
+    public void testCleanupDoesNotRunTooOften() throws Exception {
+        // Set the system clock to just before the task should run.
+        SystemClock.setCurrentTimeMillis(WebappRegistry.FULL_CLEANUP_DURATION - 1);

[gone, 2015/09/24 10:27:12]

instead of mucking about with the clock, add some way of passing in the time
when the WebappRegistry needs it.  example of why mucking about with system
settings is bad: you don't reset it at the end of the test, and I don't know if
Robolectric handles that for you.

[Lalit Maganti, 2015/09/24 12:35:44]

Done.

+
+        addWebappsToRegistry("test");

[gone, 2015/09/24 10:27:12]

nit: can you use something other than "test"?  it's too generic.

[Lalit Maganti, 2015/09/24 12:35:44]

Done.

+        SharedPreferences webAppPrefs = Robolectric.application.getSharedPreferences(
+                WebappDataStorage.SHARED_PREFS_FILE_PREFIX + "test", Context.MODE_PRIVATE);
+        webAppPrefs.edit()
+                .putLong(WebappDataStorage.KEY_LAST_USED, Long.MIN_VALUE)
+                .commit();
+
+        WebappRegistry.unregisterOldWebapps(Robolectric.application);
+        BackgroundShadowAsyncTask.runBackgroundTasks();
+
+        Set<String> actual = mSharedPreferences.getStringSet(
+                WebappRegistry.KEY_WEBAPP_SET, Collections.<String>emptySet());
+        assertEquals(new HashSet<String>(Arrays.asList("test")), actual);
+
+        long actualLastUsed = webAppPrefs.getLong(WebappDataStorage.KEY_LAST_USED,
+                WebappDataStorage.INVALID_LAST_USED);
+        assertEquals(Long.MIN_VALUE, actualLastUsed);
+    }
+
+    @Test
+    @Feature({"Webapp"})
+    public void testCleanupDoesNotRemoveRecentApps() throws Exception {
+        // Set the system clock to just before the task should run.
+        SystemClock.setCurrentTimeMillis(WebappRegistry.FULL_CLEANUP_DURATION);
+
+        addWebappsToRegistry("test");
+        SharedPreferences webAppPrefs = Robolectric.application.getSharedPreferences(
+                WebappDataStorage.SHARED_PREFS_FILE_PREFIX + "test", Context.MODE_PRIVATE);
+
+        // Put the last used time just inside the no-cleanup window.
+        long lastUsed =
+                System.currentTimeMillis() - WebappRegistry.WEBAPP_NON_OPEN_CLEANUP_DURATION + 1;
+        webAppPrefs.edit()
+                .putLong(WebappDataStorage.KEY_LAST_USED, lastUsed)
+                .commit();
+
+        WebappRegistry.unregisterOldWebapps(Robolectric.application);
+        BackgroundShadowAsyncTask.runBackgroundTasks();
+
+        Set<String> actual = mSharedPreferences.getStringSet(
+                WebappRegistry.KEY_WEBAPP_SET, Collections.<String>emptySet());
+        assertEquals(new HashSet<String>(Arrays.asList("test")), actual);
+
+        long actualLastUsed = webAppPrefs.getLong(WebappDataStorage.KEY_LAST_USED,
+                WebappDataStorage.INVALID_LAST_USED);
+        assertEquals(lastUsed, actualLastUsed);
+    }
+
+    @Test
+    @Feature({"Webapp"})
+    public void testCleanupRemovesOldApps() throws Exception {
+        // Set the system clock to just before the task should run.
+        SystemClock.setCurrentTimeMillis(WebappRegistry.FULL_CLEANUP_DURATION);
+
+        addWebappsToRegistry("test");
+        SharedPreferences webAppPrefs = Robolectric.application.getSharedPreferences(
+                WebappDataStorage.SHARED_PREFS_FILE_PREFIX + "test", Context.MODE_PRIVATE);
+
+        // Put the last used time just outside the no-cleanup window.
+        long lastUsed = System.currentTimeMillis()
+                - WebappRegistry.WEBAPP_NON_OPEN_CLEANUP_DURATION;
+        webAppPrefs.edit()
+                .putLong(WebappDataStorage.KEY_LAST_USED, lastUsed)
+                .commit();
+
+        WebappRegistry.unregisterOldWebapps(Robolectric.application);
+        BackgroundShadowAsyncTask.runBackgroundTasks();
+
+        Set<String> actual = mSharedPreferences.getStringSet(
+                WebappRegistry.KEY_WEBAPP_SET, Collections.<String>emptySet());
+        assertTrue(actual.isEmpty());
+
+        long actualLastUsed = webAppPrefs.getLong(WebappDataStorage.KEY_LAST_USED,
+                WebappDataStorage.INVALID_LAST_USED);
+        assertEquals(WebappDataStorage.INVALID_LAST_USED, actualLastUsed);
+    }
+
     private Set<String> addWebappsToRegistry(String... webapps) {
         final Set<String> expected = new HashSet<String>(Arrays.asList(webapps));
         mSharedPreferences.edit()
                 .putStringSet(WebappRegistry.KEY_WEBAPP_SET, expected)
                 .commit();
         return expected;
     }
 
     private Set<String> getRegisteredWebapps() {
         return mSharedPreferences.getStringSet(
                 WebappRegistry.KEY_WEBAPP_SET, Collections.<String>emptySet());
     }
 }