Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: components/cronet/android/java/src/org/chromium/net/UrlRequestListener.java

Issue 1359343005: Update ResponseInfo to UrlResponseInfo with API review comments. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update README.md Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/java/src/org/chromium/net/UrlRequestListener.java
diff --git a/components/cronet/android/java/src/org/chromium/net/UrlRequestListener.java b/components/cronet/android/java/src/org/chromium/net/UrlRequestListener.java
index f3803f06774f935c76e7a4a8af2c9b462a88d534..2c967286100e7907ae8ff5f24406c123d1aa9085 100644
--- a/components/cronet/android/java/src/org/chromium/net/UrlRequestListener.java
+++ b/components/cronet/android/java/src/org/chromium/net/UrlRequestListener.java
@@ -33,7 +33,7 @@ public abstract class UrlRequestListener {
* @param newLocationUrl Location where request is redirected.
*/
public abstract void onReceivedRedirect(
- UrlRequest request, ResponseInfo info, String newLocationUrl);
+ UrlRequest request, UrlResponseInfo info, String newLocationUrl);
/**
* Called when the final set of headers, after all redirects, is received.
@@ -48,7 +48,7 @@ public abstract class UrlRequestListener {
* @param request Request that started to get response.
* @param info Response information.
*/
- public abstract void onResponseStarted(UrlRequest request, ResponseInfo info);
+ public abstract void onResponseStarted(UrlRequest request, UrlResponseInfo info);
/**
* Called whenever part of the response body has been read. Only part of
@@ -69,7 +69,7 @@ public abstract class UrlRequestListener {
* buffer's limit is not changed.
*/
public abstract void onReadCompleted(
- UrlRequest request, ResponseInfo info, ByteBuffer byteBuffer);
+ UrlRequest request, UrlResponseInfo info, ByteBuffer byteBuffer);
/**
* Called when request is completed successfully, no callbacks will be
@@ -78,7 +78,7 @@ public abstract class UrlRequestListener {
* @param request Request that succeeded.
* @param info Response information.
*/
- public abstract void onSucceeded(UrlRequest request, ExtendedResponseInfo info);
+ public abstract void onSucceeded(UrlRequest request, UrlResponseInfo info);
/**
* Called if request failed for any reason after start(). Once
@@ -86,8 +86,9 @@ public abstract class UrlRequestListener {
* provides information about error.
*
* @param request Request that failed.
- * @param info Response information.
+ * @param info Response information. May be {@code null} if no response was received.
* @param error information about error.
*/
- public abstract void onFailed(UrlRequest request, ResponseInfo info, UrlRequestException error);
+ public abstract void onFailed(
+ UrlRequest request, UrlResponseInfo info, UrlRequestException error);
}

Powered by Google App Engine
This is Rietveld 408576698