Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: components/cronet/README.md

Issue 1359343005: Update ResponseInfo to UrlResponseInfo with API review comments. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update README.md Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/cronet.gypi ('k') | components/cronet/android/cronet_url_request_adapter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/README.md
diff --git a/components/cronet/README.md b/components/cronet/README.md
index 4d23a544fd53f91e72d042d89e55dd7a3b3582c9..d4c6a02dcfbe709e18c48bd7d30b843415423e12 100644
--- a/components/cronet/README.md
+++ b/components/cronet/README.md
@@ -14,7 +14,7 @@ events during the lifetime of a request. For example:
class MyListener extends UrlRequestListener {
@Override
public void onReceivedRedirect(UrlRequest request,
- ResponseInfo responseInfo, String newLocationUrl) {
+ UrlResponseInfo responseInfo, String newLocationUrl) {
if (followRedirect) {
// Let's tell Cronet to follow the redirect!
mRequest.followRedirect();
@@ -26,7 +26,7 @@ events during the lifetime of a request. For example:
@Override
public void onResponseStarted(UrlRequest request,
- ResponseInfo responseInfo) {
+ UrlResponseInfo responseInfo) {
// Now we have response headers!
int httpStatusCode = responseInfo.getHttpStatusCode();
if (httpStatusCode == 200) {
@@ -42,7 +42,7 @@ events during the lifetime of a request. For example:
@Override
public void onReadCompleted(UrlRequest request,
- ResponseInfo responseInfo, ByteBuffer byteBuffer) {
+ UrlResponseInfo responseInfo, ByteBuffer byteBuffer) {
// Response body is available.
doSomethingWithResponseData(byteBuffer);
// Let's tell Cronet to continue reading the response body or
@@ -52,13 +52,13 @@ events during the lifetime of a request. For example:
@Override
public void onSucceeded(UrlRequest request,
- ExtendedResponseInfo extendedResponseInfo) {
+ UrlResponseInfo responseInfo) {
// Request has completed successfully!
}
@Override
public void onFailed(UrlRequest request,
- ResponseInfo responseInfo, UrlRequestException error) {
+ UrlResponseInfo responseInfo, UrlRequestException error) {
// Request has failed. responseInfo might be null.
Log.e("MyListener", "Request failed. " + error.getMessage());
// Maybe handle error here. Typical errors include hostname
« no previous file with comments | « components/cronet.gypi ('k') | components/cronet/android/cronet_url_request_adapter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698